fix possible refleak (closes #14752)

89a6e9a2 · Benjamin Peterson · d9e4a414 · 89a6e9a2
Commit 89a6e9a2 authored May 08, 2012 by Benjamin Peterson
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

Objects/typeobject.c Objects/typeobject.c +4 -2

No files found.
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -3527,6 +3527,7 @@ add_methods(PyTypeObject *type, PyMethodDef *meth)
    for (; meth->ml_name != NULL; meth++) {
        PyObject *descr;
+        int err;
        if (PyDict_GetItemString(dict, meth->ml_name) &&
            !(meth->ml_flags & METH_COEXIST))
                continue;
@@ -3550,9 +3551,10 @@ add_methods(PyTypeObject *type, PyMethodDef *meth)
        }
        if (descr == NULL)
            return -1;
-        if (PyDict_SetItemString(dict, meth->ml_name, descr) < 0)
+        err = PyDict_SetItemString(dict, meth->ml_name, descr);
-            return -1;
        Py_DECREF(descr);
+        if (err < 0)
+            return -1;
    }
    return 0;
 }