Use with open() as fo: ... instead of try: fo = open(...) finally: fo.close()

fo is not set if the open() fails.

Use with open() as fo: ... instead of try: fo = open(...) finally: fo.close()
fo is not set if the open() fails.
8a470d60 · Victor Stinner · 3bea1ede · 8a470d60
Commit 8a470d60 authored May 16, 2010 by Victor Stinner
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 6 deletions

Lib/test/list_tests.py Lib/test/list_tests.py +4 -6

No files found.
--- a/Lib/test/list_tests.py
+++ b/Lib/test/list_tests.py
@@ -57,13 +57,11 @@ class CommonTest(seq_tests.CommonTest):
        d.append(d)
        d.append(400)
        try:
-            fo = open(test_support.TESTFN, "wb")
+            with open(test_support.TESTFN, "wb") as fo:
-            print >> fo, d,
+                print >> fo, d,
-            fo.close()
+            with open(test_support.TESTFN, "rb") as fo:
-            fo = open(test_support.TESTFN, "rb")
+                self.assertEqual(fo.read(), repr(d))
-            self.assertEqual(fo.read(), repr(d))
        finally:
-            fo.close()
            os.remove(test_support.TESTFN)
    def test_set_subscript(self):