Commit 8b0d84e3 authored by Victor Stinner's avatar Victor Stinner

Backport of 83120 (#9032)

XML-RPC client: Transport.request() retries on EPIPE error

The EPIPE error occurs when the server closes the socket and the client sends a
"big" XML-RPC request (I don't know exactly the size threshold).

request() just have to ignore the error because single_request() closes the
socket on error, and so the next call to single_request() will open a new
socket.

Remove also a comment in the HTTP client because it's now wrong: see r70643 and
issue #5542.
parent 2c6aee90
...@@ -1263,7 +1263,7 @@ class Transport: ...@@ -1263,7 +1263,7 @@ class Transport:
try: try:
return self.single_request(host, handler, request_body, verbose) return self.single_request(host, handler, request_body, verbose)
except socket.error, e: except socket.error, e:
if i or e.errno not in (errno.ECONNRESET, errno.ECONNABORTED): if i or e.errno not in (errno.ECONNRESET, errno.ECONNABORTED, errno.EPIPE):
raise raise
except httplib.BadStatusLine: #close after we sent request except httplib.BadStatusLine: #close after we sent request
if i: if i:
......
...@@ -18,6 +18,10 @@ Core and Builtins ...@@ -18,6 +18,10 @@ Core and Builtins
Library Library
------- -------
- Issue #9032: XML-RPC client retries the request on EPIPE error. The EPIPE
error occurs when the server closes the socket and the client sends a big
XML-RPC request.
- Issue #5542: Remove special logic that closes HTTPConnection socket on EPIPE. - Issue #5542: Remove special logic that closes HTTPConnection socket on EPIPE.
- Issue #4629: getopt raises an error if an argument ends with = whereas getopt - Issue #4629: getopt raises an error if an argument ends with = whereas getopt
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment