Commit 8bfda3af authored by Antoine Pitrou's avatar Antoine Pitrou

Issue #21976: Fix test_ssl to accept LibreSSL version strings.

Thanks to William Orr.
parent 13c40cf5
......@@ -175,11 +175,11 @@ class BasicSocketTests(unittest.TestCase):
# Some sanity checks follow
# >= 0.9
self.assertGreaterEqual(n, 0x900000)
# < 2.0
self.assertLess(n, 0x20000000)
# < 3.0
self.assertLess(n, 0x30000000)
major, minor, fix, patch, status = t
self.assertGreaterEqual(major, 0)
self.assertLess(major, 2)
self.assertLess(major, 3)
self.assertGreaterEqual(minor, 0)
self.assertLess(minor, 256)
self.assertGreaterEqual(fix, 0)
......@@ -188,9 +188,13 @@ class BasicSocketTests(unittest.TestCase):
self.assertLessEqual(patch, 26)
self.assertGreaterEqual(status, 0)
self.assertLessEqual(status, 15)
# Version string as returned by OpenSSL, the format might change
self.assertTrue(s.startswith("OpenSSL {:d}.{:d}.{:d}".format(major, minor, fix)),
(s, t))
# Version string as returned by {Open,Libre}SSL, the format might change
if "LibreSSL" in s:
self.assertTrue(s.startswith("LibreSSL {:d}.{:d}".format(major, minor)),
(s, t))
else:
self.assertTrue(s.startswith("OpenSSL {:d}.{:d}.{:d}".format(major, minor, fix)),
(s, t))
@test_support.requires_resource('network')
def test_ciphers(self):
......
......@@ -981,6 +981,7 @@ Piet van Oostrum
Tomas Oppelstrup
Jason Orendorff
Douglas Orr
William Orr
Michele Orrù
Oleg Oshmyan
Denis S. Otkidach
......
......@@ -37,6 +37,12 @@ Library
- Issue #21323: Fix CGIHTTPServer to again handle scripts in CGI subdirectories,
broken by the fix for security issue #19435. Patch by Zach Byrne.
Tests
-----
- Issue #21976: Fix test_ssl to accept LibreSSL version strings. Thanks
to William Orr.
What's New in Python 2.7.8?
===========================
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment