Commit 8cdc40e3 authored by Antoine Pitrou's avatar Antoine Pitrou

Issue #11603: Fix a crash when __str__ is rebound as __repr__.

Patch by Andreas Stührk.
parent e2281306
......@@ -4252,6 +4252,14 @@ order (MRO) for bases """
with self.assertRaises(TypeError):
str.__add__(fake_str, "abc")
def test_repr_as_str(self):
# Issue #11603: crash or infinite loop when rebinding __str__ as
# __repr__.
class Foo:
pass
Foo.__repr__ = Foo.__str__
foo = Foo()
str(foo)
class DictProxyTests(unittest.TestCase):
def setUp(self):
......
......@@ -13,6 +13,9 @@ Core and Builtins
Library
-------
- Issue #11603: Fix a crash when __str__ is rebound as __repr__. Patch by
Andreas Stührk.
What's New in Python 3.1.4?
===========================
......
......@@ -2821,7 +2821,7 @@ object_str(PyObject *self)
unaryfunc f;
f = Py_TYPE(self)->tp_repr;
if (f == NULL)
if (f == NULL || f == object_str)
f = object_repr;
return f(self);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment