Commit 8ebf5ceb authored by Ned Deily's avatar Ned Deily Committed by GitHub

bpo-33109: argparse subparsers are once again not required by default (GH-6919)

bpo-26510 in 3.7.0a2 changed the behavior of argparse to make
subparsers required by default, returning to the behavior of 2.7
and 3.2. The behavior was changed in 3.3 to be no longer required.
While it might make more sense to have the default to required,
compatibility with 3.3 through 3.6 is probably less disruptive
than trying to reintroduce compatibility with 2.7 at this point.
This change restores the 3.6 behavior.
parent 453bd0bc
......@@ -1577,7 +1577,7 @@ Sub-commands
stored; by default ``None`` and no value is stored
* required_ - Whether or not a subcommand must be provided, by default
``True``.
``False``.
* help_ - help for sub-parser group in help output, by default ``None``
......
......@@ -1077,7 +1077,7 @@ class _SubParsersAction(Action):
prog,
parser_class,
dest=SUPPRESS,
required=True,
required=False,
help=None,
metavar=None):
......
......@@ -1932,7 +1932,9 @@ class TestAddSubparsers(TestCase):
parser = ErrorRaisingArgumentParser()
subparsers = parser.add_subparsers(dest='command')
subparsers.add_parser('run')
self._test_required_subparsers(parser)
# No error here
ret = parser.parse_args(())
self.assertIsNone(ret.command)
def test_optional_subparsers(self):
parser = ErrorRaisingArgumentParser()
......
......@@ -477,6 +477,8 @@ module now requires sqlite version at least 3.3.9.
argparse subparsers are now required by default. This matches behaviour in
Python 2. For optional subparsers, use the new parameter
``add_subparsers(required=False)``. Patch by Anthony Sottile.
(As of 3.7.0rc1, the default was changed to not required as had been the case
since Python 3.3.)
..
......
argparse subparsers are once again not required by default, reverting the
change in behavior introduced by bpo-26510 in 3.7.0a2.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment