Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
8fac1221
Commit
8fac1221
authored
Jun 17, 2019
by
Terry Jan Reedy
Committed by
GitHub
Jun 17, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bpo-37321: Edit IDLE subprocess connection error messages. (#14170)
Mainly, add a doc reference to message in pyshell.
parent
5bff3c86
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
16 additions
and
9 deletions
+16
-9
Lib/idlelib/NEWS.txt
Lib/idlelib/NEWS.txt
+3
-0
Lib/idlelib/pyshell.py
Lib/idlelib/pyshell.py
+4
-4
Lib/idlelib/run.py
Lib/idlelib/run.py
+7
-5
Misc/NEWS.d/next/IDLE/2019-06-17-16-35-30.bpo-37321.zVTTGS.rst
...NEWS.d/next/IDLE/2019-06-17-16-35-30.bpo-37321.zVTTGS.rst
+2
-0
No files found.
Lib/idlelib/NEWS.txt
View file @
8fac1221
...
@@ -3,6 +3,9 @@ Released on 2019-10-20?
...
@@ -3,6 +3,9 @@ Released on 2019-10-20?
======================================
======================================
bpo-37321: Both subprocess connection error messages now refer to
the 'Startup failure' section of the IDLE doc.
bpo-37039: Adjust "Zoom Height" to individual screens by momemtarily
bpo-37039: Adjust "Zoom Height" to individual screens by momemtarily
maximizing the window on first use with a particular screen. Changing
maximizing the window on first use with a particular screen. Changing
screen settings may invalidate the saved height. While a window is
screen settings may invalidate the saved height. While a window is
...
...
Lib/idlelib/pyshell.py
View file @
8fac1221
...
@@ -824,10 +824,10 @@ class ModifiedInterpreter(InteractiveInterpreter):
...
@@ -824,10 +824,10 @@ class ModifiedInterpreter(InteractiveInterpreter):
def
display_no_subprocess_error
(
self
):
def
display_no_subprocess_error
(
self
):
tkMessageBox
.
showerror
(
tkMessageBox
.
showerror
(
"Subprocess
Startup
Error"
,
"Subprocess
Connection
Error"
,
"IDLE's subprocess didn't make connection.
Either IDLE can't
"
"IDLE's subprocess didn't make connection.
\
n
"
"
start a subprocess or personal firewall software is blocking
"
"
See the 'Startup failure' section of the IDLE doc, online at
\
n
"
"
the connection.
"
,
"
https://docs.python.org/3/library/idle.html#startup-failure
"
,
parent
=
self
.
tkconsole
.
text
)
parent
=
self
.
tkconsole
.
text
)
def
display_executing_dialog
(
self
):
def
display_executing_dialog
(
self
):
...
...
Lib/idlelib/run.py
View file @
8fac1221
...
@@ -199,11 +199,13 @@ def show_socket_error(err, address):
...
@@ -199,11 +199,13 @@ def show_socket_error(err, address):
root
=
tkinter
.
Tk
()
root
=
tkinter
.
Tk
()
fix_scaling
(
root
)
fix_scaling
(
root
)
root
.
withdraw
()
root
.
withdraw
()
msg
=
f"IDLE's subprocess can't connect to
{
address
[
0
]
}
:
{
address
[
1
]
}
.
\
n
"
\
showerror
(
f"Fatal OSError #
{
err
.
errno
}
:
{
err
.
strerror
}
.
\
n
"
\
"Subprocess Connection Error"
,
f"See the 'Startup failure' section of the IDLE doc, online at
\
n
"
\
f"IDLE's subprocess can't connect to
{
address
[
0
]
}
:
{
address
[
1
]
}
.
\
n
"
f"https://docs.python.org/3/library/idle.html#startup-failure"
f"Fatal OSError #
{
err
.
errno
}
:
{
err
.
strerror
}
.
\
n
"
showerror
(
"IDLE Subprocess Error"
,
msg
,
parent
=
root
)
"See the 'Startup failure' section of the IDLE doc, online at
\
n
"
"https://docs.python.org/3/library/idle.html#startup-failure"
,
parent
=
root
)
root
.
destroy
()
root
.
destroy
()
def
print_exception
():
def
print_exception
():
...
...
Misc/NEWS.d/next/IDLE/2019-06-17-16-35-30.bpo-37321.zVTTGS.rst
0 → 100644
View file @
8fac1221
Both subprocess connection error messages now refer to the 'Startup failure'
section of the IDLE doc.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment