Commit 8fac1221 authored by Terry Jan Reedy's avatar Terry Jan Reedy Committed by GitHub

bpo-37321: Edit IDLE subprocess connection error messages. (#14170)

Mainly, add a doc reference to message in pyshell.
parent 5bff3c86
...@@ -3,6 +3,9 @@ Released on 2019-10-20? ...@@ -3,6 +3,9 @@ Released on 2019-10-20?
====================================== ======================================
bpo-37321: Both subprocess connection error messages now refer to
the 'Startup failure' section of the IDLE doc.
bpo-37039: Adjust "Zoom Height" to individual screens by momemtarily bpo-37039: Adjust "Zoom Height" to individual screens by momemtarily
maximizing the window on first use with a particular screen. Changing maximizing the window on first use with a particular screen. Changing
screen settings may invalidate the saved height. While a window is screen settings may invalidate the saved height. While a window is
......
...@@ -824,10 +824,10 @@ class ModifiedInterpreter(InteractiveInterpreter): ...@@ -824,10 +824,10 @@ class ModifiedInterpreter(InteractiveInterpreter):
def display_no_subprocess_error(self): def display_no_subprocess_error(self):
tkMessageBox.showerror( tkMessageBox.showerror(
"Subprocess Startup Error", "Subprocess Connection Error",
"IDLE's subprocess didn't make connection. Either IDLE can't " "IDLE's subprocess didn't make connection.\n"
"start a subprocess or personal firewall software is blocking " "See the 'Startup failure' section of the IDLE doc, online at\n"
"the connection.", "https://docs.python.org/3/library/idle.html#startup-failure",
parent=self.tkconsole.text) parent=self.tkconsole.text)
def display_executing_dialog(self): def display_executing_dialog(self):
......
...@@ -199,11 +199,13 @@ def show_socket_error(err, address): ...@@ -199,11 +199,13 @@ def show_socket_error(err, address):
root = tkinter.Tk() root = tkinter.Tk()
fix_scaling(root) fix_scaling(root)
root.withdraw() root.withdraw()
msg = f"IDLE's subprocess can't connect to {address[0]}:{address[1]}.\n"\ showerror(
f"Fatal OSError #{err.errno}: {err.strerror}.\n"\ "Subprocess Connection Error",
f"See the 'Startup failure' section of the IDLE doc, online at\n"\ f"IDLE's subprocess can't connect to {address[0]}:{address[1]}.\n"
f"https://docs.python.org/3/library/idle.html#startup-failure" f"Fatal OSError #{err.errno}: {err.strerror}.\n"
showerror("IDLE Subprocess Error", msg, parent=root) "See the 'Startup failure' section of the IDLE doc, online at\n"
"https://docs.python.org/3/library/idle.html#startup-failure",
parent=root)
root.destroy() root.destroy()
def print_exception(): def print_exception():
......
Both subprocess connection error messages now refer to the 'Startup failure'
section of the IDLE doc.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment