Add a note explaining why dict_update() doesn't use METH_FASTCALL

Issue #29312.

Add a note explaining why dict_update() doesn't use METH_FASTCALL
Issue #29312.
91f0d4aa · Victor Stinner · 7dc6a5f5 · 91f0d4aa
Commit 91f0d4aa authored Jan 19, 2017 by Victor Stinner
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

Objects/dictobject.c Objects/dictobject.c +3 -0

No files found.
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -2347,6 +2347,9 @@ dict_update_common(PyObject *self, PyObject *args, PyObject *kwds,
    return result;
 }

+/* Note: dict.update() uses the METH_VARARGS|METH_KEYWORDS calling convention.
+   Using METH_FASTCALL would make dict.update(**dict2) calls slower, see the
+   issue #29312. */
 static PyObject *
 dict_update(PyObject *self, PyObject *args, PyObject *kwds)
 {