Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
92a5bf0c
Commit
92a5bf0c
authored
May 16, 2012
by
Senthil Kumaran
Browse files
Options
Browse Files
Download
Plain Diff
Issue12541 - Add UserWarning for unquoted realms
parents
acfc26ac
0ea91cb5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
5 deletions
+9
-5
Lib/test/test_urllib2.py
Lib/test/test_urllib2.py
+6
-5
Lib/urllib/request.py
Lib/urllib/request.py
+3
-0
No files found.
Lib/test/test_urllib2.py
View file @
92a5bf0c
...
...
@@ -1261,11 +1261,12 @@ class HandlerTests(unittest.TestCase):
401
,
'WWW-Authenticate: Basic realm=%s
\
r
\
n
\
r
\
n
'
%
realm
)
opener
.
add_handler
(
auth_handler
)
opener
.
add_handler
(
http_handler
)
self
.
_test_basic_auth
(
opener
,
auth_handler
,
"Authorization"
,
realm
,
http_handler
,
password_manager
,
"http://acme.example.com/protected"
,
"http://acme.example.com/protected"
,
)
with
self
.
assertWarns
(
UserWarning
):
self
.
_test_basic_auth
(
opener
,
auth_handler
,
"Authorization"
,
realm
,
http_handler
,
password_manager
,
"http://acme.example.com/protected"
,
"http://acme.example.com/protected"
,
)
def
test_proxy_basic_auth
(
self
):
opener
=
OpenerDirector
()
...
...
Lib/urllib/request.py
View file @
92a5bf0c
...
...
@@ -934,6 +934,9 @@ class AbstractBasicAuthHandler:
mo
=
AbstractBasicAuthHandler
.
rx
.
search
(
authreq
)
if
mo
:
scheme
,
quote
,
realm
=
mo
.
groups
()
if
quote
not
in
[
'"'
,
"'"
]:
warnings
.
warn
(
"Basic Auth Realm was unquoted"
,
UserWarning
,
2
)
if
scheme
.
lower
()
==
'basic'
:
response
=
self
.
retry_http_basic_auth
(
host
,
req
,
realm
)
if
response
and
response
.
code
!=
401
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment