Commit 936efc79 authored by Vinay Sajip's avatar Vinay Sajip

Issue #8924: logging: Improved error handling for Unicode in exception text.

parent cca3a3f3
...@@ -473,7 +473,13 @@ class Formatter(object): ...@@ -473,7 +473,13 @@ class Formatter(object):
if record.exc_text: if record.exc_text:
if s[-1:] != "\n": if s[-1:] != "\n":
s = s + "\n" s = s + "\n"
s = s + record.exc_text try:
s = s + record.exc_text
except UnicodeError:
# Sometimes filenames have non-ASCII chars, which can lead
# to errors when s is Unicode and record.exc_text is str
# See issue 8924
s = s + record.exc_text.decode(sys.getfilesystemencoding())
return s return s
# #
......
...@@ -21,6 +21,7 @@ Core and Builtins ...@@ -21,6 +21,7 @@ Core and Builtins
Library Library
------- -------
- Issue #8924: logging: Improved error handling for Unicode in exception text.
- Issue #8948: cleanup functions and class / module setups and teardowns are - Issue #8948: cleanup functions and class / module setups and teardowns are
now honored in unittest debug methods. now honored in unittest debug methods.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment