Commit 94c001b5 authored by Brian Curtin's avatar Brian Curtin

Fix email post-commit review comments.

Add INCREFs, fix args->kwargs, and a second args==NULL check was removed,
left over from a merger with another function. Instead, checking msg==NULL
does what that used to do in a roundabout way.
parent 03c7ed15
...@@ -590,29 +590,32 @@ PyErr_SetImportError(PyObject *msg, PyObject *name, PyObject *path) ...@@ -590,29 +590,32 @@ PyErr_SetImportError(PyObject *msg, PyObject *name, PyObject *path)
{ {
PyObject *args, *kwargs, *error; PyObject *args, *kwargs, *error;
if (msg == NULL)
return NULL;
args = PyTuple_New(1); args = PyTuple_New(1);
if (args == NULL) if (args == NULL)
return NULL; return NULL;
kwargs = PyDict_New(); kwargs = PyDict_New();
if (args == NULL) if (kwargs == NULL)
return NULL; return NULL;
if (name == NULL) if (name == NULL) {
Py_INCREF(Py_None);
name = Py_None; name = Py_None;
}
if (path == NULL) if (path == NULL) {
Py_INCREF(Py_None);
path = Py_None; path = Py_None;
}
Py_INCREF(msg); Py_INCREF(msg);
PyTuple_SetItem(args, 0, msg); PyTuple_SetItem(args, 0, NULL);//msg);
PyDict_SetItemString(kwargs, "name", name); PyDict_SetItemString(kwargs, "name", name);
PyDict_SetItemString(kwargs, "path", path); PyDict_SetItemString(kwargs, "path", path);
/* args must at least be an empty tuple */
if (args == NULL)
args = PyTuple_New(0);
error = PyObject_Call(PyExc_ImportError, args, kwargs); error = PyObject_Call(PyExc_ImportError, args, kwargs);
if (error!= NULL) { if (error!= NULL) {
PyErr_SetObject((PyObject *) Py_TYPE(error), error); PyErr_SetObject((PyObject *) Py_TYPE(error), error);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment