Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by Thomas

Jarosch.

Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by Thomas
Jarosch.
9624a764 · Charles-François Natali · a0702ab1 · 5a4a1096 · 9624a764 · 9624a764
Commit 9624a764 authored Sep 29, 2011 by Charles-François Natali
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

Misc/ACKS Misc/ACKS +1 -0

Misc/NEWS Misc/NEWS +3 -0

Modules/ossaudiodev.c Modules/ossaudiodev.c +1 -0

No files found.
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -463,6 +463,7 @@ Bertrand Janin
 Geert Jansen
 Jack Jansen
 Bill Janssen
+Thomas Jarosch
 Julien Jehannet
 Drew Jenkins
 Flemming Kjær Jensen

--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -1298,6 +1298,9 @@ Tools/Demos
 Extension Modules
 -----------------
+- Issue #13058: ossaudiodev: fix a file descriptor leak on error. Patch by
+  Thomas Jarosch.
 - Issue #13013: ctypes: Fix a reference leak in PyCArrayType_from_ctype.
  Thanks to Suman Saha for finding the bug and providing a patch.

--- a/Modules/ossaudiodev.c
+++ b/Modules/ossaudiodev.c
@@ -129,6 +129,7 @@ newossobject(PyObject *arg)
    }
    if (ioctl(fd, SNDCTL_DSP_GETFMTS, &afmts) == -1) {
+        close(fd);
        PyErr_SetFromErrnoWithFilename(PyExc_IOError, devicename);
        return NULL;
    }