Commit 9a47d8e5 authored by Vinay Sajip's avatar Vinay Sajip

Closes #13661: Check added for type of logger name.

parent 9e1bc826
...@@ -1007,6 +1007,8 @@ class Manager(object): ...@@ -1007,6 +1007,8 @@ class Manager(object):
placeholder to now point to the logger. placeholder to now point to the logger.
""" """
rv = None rv = None
if not isinstance(name, basestring):
raise ValueError('A logger name must be string or Unicode')
if isinstance(name, unicode): if isinstance(name, unicode):
name = name.encode('utf-8') name = name.encode('utf-8')
_acquireLock() _acquireLock()
......
...@@ -272,6 +272,8 @@ class BuiltinLevelsTest(BaseTest): ...@@ -272,6 +272,8 @@ class BuiltinLevelsTest(BaseTest):
('INF.BADPARENT', 'INFO', '4'), ('INF.BADPARENT', 'INFO', '4'),
]) ])
def test_invalid_name(self):
self.assertRaises(ValueError, logging.getLogger, any)
class BasicFilterTest(BaseTest): class BasicFilterTest(BaseTest):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment