Commit 9a9e5989 authored by Antoine Pitrou's avatar Antoine Pitrou

Merged revisions 80480 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r80480 | antoine.pitrou | 2010-04-25 23:15:50 +0200 (dim., 25 avril 2010) | 3 lines

  Replace a Lock with a better suited Event.
........
parent 8e952056
...@@ -32,14 +32,14 @@ class TestServerThread(threading.Thread): ...@@ -32,14 +32,14 @@ class TestServerThread(threading.Thread):
threading.Thread.__init__(self) threading.Thread.__init__(self)
self.request_handler = request_handler self.request_handler = request_handler
self.test_object = test_object self.test_object = test_object
self.test_object.lock.acquire()
def run(self): def run(self):
self.server = HTTPServer(('', 0), self.request_handler) self.server = HTTPServer(('', 0), self.request_handler)
self.test_object.PORT = self.server.socket.getsockname()[1] self.test_object.PORT = self.server.socket.getsockname()[1]
self.test_object.lock.release() self.test_object.server_started.set()
self.test_object = None
try: try:
self.server.serve_forever() self.server.serve_forever(0.05)
finally: finally:
self.server.server_close() self.server.server_close()
...@@ -49,13 +49,12 @@ class TestServerThread(threading.Thread): ...@@ -49,13 +49,12 @@ class TestServerThread(threading.Thread):
class BaseTestCase(unittest.TestCase): class BaseTestCase(unittest.TestCase):
def setUp(self): def setUp(self):
self.lock = threading.Lock() self.server_started = threading.Event()
self.thread = TestServerThread(self, self.request_handler) self.thread = TestServerThread(self, self.request_handler)
self.thread.start() self.thread.start()
self.lock.acquire() self.server_started.wait()
def tearDown(self): def tearDown(self):
self.lock.release()
self.thread.stop() self.thread.stop()
def request(self, uri, method='GET', body=None, headers={}): def request(self, uri, method='GET', body=None, headers={}):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment