Commit 9cc402a9 authored by Daniel Stutzbach's avatar Daniel Stutzbach

Issue #808164: Fixed socket.close to avoid references to globals, to

avoid issues when socket.close is called from a __del__ method.
parent 82654208
......@@ -189,7 +189,9 @@ class _socketobject(object):
for method in _delegate_methods:
setattr(self, method, getattr(_sock, method))
def close(self):
def close(self, _closedsocket=_closedsocket,
_delegate_methods=_delegate_methods, setattr=setattr):
# This function should not reference any globals. See issue #808164.
self._sock = _closedsocket()
dummy = self._sock._dummy
for method in _delegate_methods:
......
......@@ -33,6 +33,9 @@ Core and Builtins
Library
-------
- Issue #808164: Fixed socket.close to avoid references to globals, to
avoid issues when socket.close is called from a __del__ method.
- Issue #8797: urllib2 does a retry for Basic Authentication failure instead of
falling into recursion.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment