Fixed possible reference leak to mod when type_name() returns NULL

a0e7e41c · Christian Heimes · d5a88044 · a0e7e41c
Commit a0e7e41c authored Sep 10, 2012 by Christian Heimes
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

Objects/typeobject.c Objects/typeobject.c +3 -1

No files found.
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -647,8 +647,10 @@ type_repr(PyTypeObject *type)
        mod = NULL;
    }
    name = type_name(type, NULL);
-    if (name == NULL)
+    if (name == NULL) {
+        Py_XDECREF(mod);
        return NULL;
+    }

    if (mod != NULL && PyUnicode_CompareWithASCIIString(mod, "builtins"))
        rtn = PyUnicode_FromFormat("<class '%U.%U'>", mod, name);