Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
a1e627d6
Commit
a1e627d6
authored
Sep 03, 2010
by
Fred Drake
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix output from RawConfigParser.write and ConfigParser.write for None
values (
http://bugs.python.org/issue7005
)
parent
5cd2d8c7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
32 additions
and
1 deletion
+32
-1
Lib/ConfigParser.py
Lib/ConfigParser.py
+1
-1
Lib/test/test_cfgparser.py
Lib/test/test_cfgparser.py
+28
-0
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/ConfigParser.py
View file @
a1e627d6
...
...
@@ -400,7 +400,7 @@ class RawConfigParser:
for
(
key
,
value
)
in
self
.
_sections
[
section
].
items
():
if
key
==
"__name__"
:
continue
if
value
is
not
None
:
if
(
value
is
not
None
)
or
(
self
.
_optcre
==
self
.
OPTCRE
)
:
key
=
" = "
.
join
((
key
,
str
(
value
).
replace
(
'
\
n
'
,
'
\
n
\
t
'
)))
fp
.
write
(
"%s
\
n
"
%
(
key
))
fp
.
write
(
"
\
n
"
)
...
...
Lib/test/test_cfgparser.py
View file @
a1e627d6
...
...
@@ -530,6 +530,33 @@ class SafeConfigParserTestCaseNoValue(SafeConfigParserTestCase):
allow_no_value
=
True
class
Issue7005TestCase
(
unittest
.
TestCase
):
"""Test output when None is set() as a value and allow_no_value == False.
http://bugs.python.org/issue7005
"""
expected_output
=
"[section]
\
n
option = None
\
n
\
n
"
def
prepare
(
self
,
config_class
):
# This is the default, but that's the point.
cp
=
config_class
(
allow_no_value
=
False
)
cp
.
add_section
(
"section"
)
cp
.
set
(
"section"
,
"option"
,
None
)
sio
=
StringIO
.
StringIO
()
cp
.
write
(
sio
)
return
sio
.
getvalue
()
def
test_none_as_value_stringified
(
self
):
output
=
self
.
prepare
(
ConfigParser
.
ConfigParser
)
self
.
assertEqual
(
output
,
self
.
expected_output
)
def
test_none_as_value_stringified_raw
(
self
):
output
=
self
.
prepare
(
ConfigParser
.
RawConfigParser
)
self
.
assertEqual
(
output
,
self
.
expected_output
)
class
SortedTestCase
(
RawConfigParserTestCase
):
def
newconfig
(
self
,
defaults
=
None
):
self
.
cf
=
self
.
config_class
(
defaults
=
defaults
,
dict_type
=
SortedDict
)
...
...
@@ -563,6 +590,7 @@ def test_main():
SafeConfigParserTestCase
,
SafeConfigParserTestCaseNoValue
,
SortedTestCase
,
Issue7005TestCase
,
)
...
...
Misc/NEWS
View file @
a1e627d6
...
...
@@ -36,6 +36,9 @@ Core and Builtins
Library
-------
- Issue #7005: Fixed output of None values for RawConfigParser.write and
ConfigParser.write.
- Issue #808164: Fixed socket.close to avoid references to globals, to
avoid issues when socket.close is called from a __del__ method.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment