Issue #18408: Fix PyType_Ready(), handle _PyDict_SetItemId() failure

a8c1a8b3 · Victor Stinner · 913ebb18 · a8c1a8b3
Commit a8c1a8b3 authored Jul 17, 2013 by Victor Stinner
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 3 deletions

Objects/typeobject.c Objects/typeobject.c +7 -3

No files found.
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -4256,11 +4256,15 @@ PyType_Ready(PyTypeObject *type)
            PyObject *doc = PyUnicode_FromString(type->tp_doc);
            if (doc == NULL)
                goto error;
-            _PyDict_SetItemId(type->tp_dict, &PyId___doc__, doc);
+            if (_PyDict_SetItemId(type->tp_dict, &PyId___doc__, doc) < 0) {
+                Py_DECREF(doc);
+                goto error;
+            }
            Py_DECREF(doc);
        } else {
-            _PyDict_SetItemId(type->tp_dict,
-                              &PyId___doc__, Py_None);
+            if (_PyDict_SetItemId(type->tp_dict,
+                                  &PyId___doc__, Py_None) < 0)
+                goto error;
        }
    }