Commit aa1e1a27 authored by Ned Deily's avatar Ned Deily

Issue #17111: Prevent test_surrogates (test_fileio) failure on OS X 10.4.

An odd bug in OS X 10.4 causes open(2) on a non-existent,
invalid-encoded filename to return errno 22, EINVAL: Invalid argument,
instead of the expected errno 2, ENOENT: No such file or directory,
*if* the containing directory is not empty.  That caused frequent
failures when running the buildbot tests on 10.4 depending on the state
of the test working directory.  The failure is easy to reproduce on
10.4 by running the test directly (not with regrtest), first in an empty
directory, then after adding a file to it.  The fix is to check for and
pass if either errno is returned.
parent c114cc86
...@@ -450,8 +450,9 @@ class OtherFileTests(unittest.TestCase): ...@@ -450,8 +450,9 @@ class OtherFileTests(unittest.TestCase):
env = dict(os.environ) env = dict(os.environ)
env[b'LC_CTYPE'] = b'C' env[b'LC_CTYPE'] = b'C'
_, out = run_python('-c', 'import _io; _io.FileIO(%r)' % filename, env=env) _, out = run_python('-c', 'import _io; _io.FileIO(%r)' % filename, env=env)
if ('UnicodeEncodeError' not in out and if ('UnicodeEncodeError' not in out and not
'IOError: [Errno 2] No such file or directory' not in out): ( ('IOError: [Errno 2] No such file or directory' in out) or
('IOError: [Errno 22] Invalid argument' in out) ) ):
self.fail('Bad output: %r' % out) self.fail('Bad output: %r' % out)
def testUnclosedFDOnException(self): def testUnclosedFDOnException(self):
......
...@@ -818,6 +818,8 @@ Tests ...@@ -818,6 +818,8 @@ Tests
- Issue #16698: Skip posix test_getgroups when built with OS X - Issue #16698: Skip posix test_getgroups when built with OS X
deployment target prior to 10.6. deployment target prior to 10.6.
- Issue #17111: Prevent test_surrogates (test_fileio) failure on OS X 10.4.
Build Build
----- -----
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment