Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
ab53ab0a
Commit
ab53ab0a
authored
Feb 03, 2015
by
Berker Peksag
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #13128: Print response headers for CONNECT requests when debuglevel > 0.
Patch by Demian Brecht.
parent
50457403
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
24 additions
and
5 deletions
+24
-5
Lib/http/client.py
Lib/http/client.py
+3
-0
Lib/test/test_httplib.py
Lib/test/test_httplib.py
+18
-5
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/http/client.py
View file @
ab53ab0a
...
...
@@ -776,6 +776,9 @@ class HTTPConnection:
if
line
in
(
b'
\
r
\
n
'
,
b'
\
n
'
,
b''
):
break
if
self
.
debuglevel
>
0
:
print
(
'header:'
,
line
.
decode
())
def
connect
(
self
):
"""Connect to the host and port specified in __init__."""
self
.
sock
=
self
.
_create_connection
(
...
...
Lib/test/test_httplib.py
View file @
ab53ab0a
...
...
@@ -1269,17 +1269,18 @@ class TunnelTests(TestCase):
'HTTP/1.1 200 OK
\
r
\
n
'
# Reply to HEAD
'Content-Length: 42
\
r
\
n
\
r
\
n
'
)
def
create_connection
(
address
,
timeout
=
None
,
source_address
=
None
):
return
FakeSocket
(
response_text
,
host
=
address
[
0
],
port
=
address
[
1
])
self
.
host
=
'proxy.com'
self
.
conn
=
client
.
HTTPConnection
(
self
.
host
)
self
.
conn
.
_create_connection
=
create_connection
self
.
conn
.
_create_connection
=
self
.
_create_connection
(
response_text
)
def
tearDown
(
self
):
self
.
conn
.
close
()
def
_create_connection
(
self
,
response_text
):
def
create_connection
(
address
,
timeout
=
None
,
source_address
=
None
):
return
FakeSocket
(
response_text
,
host
=
address
[
0
],
port
=
address
[
1
])
return
create_connection
def
test_set_tunnel_host_port_headers
(
self
):
tunnel_host
=
'destination.com'
tunnel_port
=
8888
...
...
@@ -1320,6 +1321,18 @@ class TunnelTests(TestCase):
self
.
assertIn
(
b'CONNECT destination.com'
,
self
.
conn
.
sock
.
data
)
self
.
assertIn
(
b'Host: destination.com'
,
self
.
conn
.
sock
.
data
)
def
test_tunnel_debuglog
(
self
):
expected_header
=
'X-Dummy: 1'
response_text
=
'HTTP/1.0 200 OK
\
r
\
n
{}
\
r
\
n
\
r
\
n
'
.
format
(
expected_header
)
self
.
conn
.
set_debuglevel
(
1
)
self
.
conn
.
_create_connection
=
self
.
_create_connection
(
response_text
)
self
.
conn
.
set_tunnel
(
'destination.com'
)
with
support
.
captured_stdout
()
as
output
:
self
.
conn
.
request
(
'PUT'
,
'/'
,
''
)
lines
=
output
.
getvalue
().
splitlines
()
self
.
assertIn
(
'header: {}'
.
format
(
expected_header
),
lines
)
@
support
.
reap_threads
...
...
Misc/NEWS
View file @
ab53ab0a
...
...
@@ -232,6 +232,9 @@ Core and Builtins
Library
-------
- Issue #13128: Print response headers for CONNECT requests when debuglevel
> 0. Patch by Demian Brecht.
- Issue #15381: Optimized io.BytesIO to make less allocations and copyings.
- Issue #22818: Splitting on a pattern that could match an empty string now
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment