Commit ac25affb authored by Ned Deily's avatar Ned Deily

Issue #20939: Use www.example.com instead of www.python.org to avoid test

failures when ssl is not present.
parent ccfd94d7
...@@ -84,7 +84,7 @@ class CloseSocketTest(unittest.TestCase): ...@@ -84,7 +84,7 @@ class CloseSocketTest(unittest.TestCase):
# calling .close() on urllib2's response objects should close the # calling .close() on urllib2's response objects should close the
# underlying socket # underlying socket
response = _urlopen_with_retry("http://www.python.org/") response = _urlopen_with_retry("http://www.example.com/")
sock = response.fp sock = response.fp
self.assertTrue(not sock.closed) self.assertTrue(not sock.closed)
response.close() response.close()
...@@ -254,7 +254,7 @@ class OtherNetworkTests(unittest.TestCase): ...@@ -254,7 +254,7 @@ class OtherNetworkTests(unittest.TestCase):
class TimeoutTest(unittest.TestCase): class TimeoutTest(unittest.TestCase):
def test_http_basic(self): def test_http_basic(self):
self.assertTrue(socket.getdefaulttimeout() is None) self.assertTrue(socket.getdefaulttimeout() is None)
url = "http://www.python.org" url = "http://www.example.com"
with support.transient_internet(url, timeout=None): with support.transient_internet(url, timeout=None):
u = _urlopen_with_retry(url) u = _urlopen_with_retry(url)
self.addCleanup(u.close) self.addCleanup(u.close)
...@@ -262,7 +262,7 @@ class TimeoutTest(unittest.TestCase): ...@@ -262,7 +262,7 @@ class TimeoutTest(unittest.TestCase):
def test_http_default_timeout(self): def test_http_default_timeout(self):
self.assertTrue(socket.getdefaulttimeout() is None) self.assertTrue(socket.getdefaulttimeout() is None)
url = "http://www.python.org" url = "http://www.example.com"
with support.transient_internet(url): with support.transient_internet(url):
socket.setdefaulttimeout(60) socket.setdefaulttimeout(60)
try: try:
...@@ -274,7 +274,7 @@ class TimeoutTest(unittest.TestCase): ...@@ -274,7 +274,7 @@ class TimeoutTest(unittest.TestCase):
def test_http_no_timeout(self): def test_http_no_timeout(self):
self.assertTrue(socket.getdefaulttimeout() is None) self.assertTrue(socket.getdefaulttimeout() is None)
url = "http://www.python.org" url = "http://www.example.com"
with support.transient_internet(url): with support.transient_internet(url):
socket.setdefaulttimeout(60) socket.setdefaulttimeout(60)
try: try:
...@@ -285,7 +285,7 @@ class TimeoutTest(unittest.TestCase): ...@@ -285,7 +285,7 @@ class TimeoutTest(unittest.TestCase):
self.assertTrue(u.fp.raw._sock.gettimeout() is None) self.assertTrue(u.fp.raw._sock.gettimeout() is None)
def test_http_timeout(self): def test_http_timeout(self):
url = "http://www.python.org" url = "http://www.example.com"
with support.transient_internet(url): with support.transient_internet(url):
u = _urlopen_with_retry(url, timeout=120) u = _urlopen_with_retry(url, timeout=120)
self.addCleanup(u.close) self.addCleanup(u.close)
......
...@@ -24,8 +24,8 @@ class URLTimeoutTest(unittest.TestCase): ...@@ -24,8 +24,8 @@ class URLTimeoutTest(unittest.TestCase):
socket.setdefaulttimeout(None) socket.setdefaulttimeout(None)
def testURLread(self): def testURLread(self):
with support.transient_internet("www.python.org"): with support.transient_internet("www.example.com"):
f = urllib.request.urlopen("http://www.python.org/") f = urllib.request.urlopen("http://www.example.com/")
x = f.read() x = f.read()
...@@ -38,7 +38,7 @@ class urlopenNetworkTests(unittest.TestCase): ...@@ -38,7 +38,7 @@ class urlopenNetworkTests(unittest.TestCase):
for transparent redirection have been written. for transparent redirection have been written.
setUp is not used for always constructing a connection to setUp is not used for always constructing a connection to
http://www.python.org/ since there a few tests that don't use that address http://www.example.com/ since there a few tests that don't use that address
and making a connection is expensive enough to warrant minimizing unneeded and making a connection is expensive enough to warrant minimizing unneeded
connections. connections.
...@@ -56,7 +56,7 @@ class urlopenNetworkTests(unittest.TestCase): ...@@ -56,7 +56,7 @@ class urlopenNetworkTests(unittest.TestCase):
def test_basic(self): def test_basic(self):
# Simple test expected to pass. # Simple test expected to pass.
with self.urlopen("http://www.python.org/") as open_url: with self.urlopen("http://www.example.com/") as open_url:
for attr in ("read", "readline", "readlines", "fileno", "close", for attr in ("read", "readline", "readlines", "fileno", "close",
"info", "geturl"): "info", "geturl"):
self.assertTrue(hasattr(open_url, attr), "object returned from " self.assertTrue(hasattr(open_url, attr), "object returned from "
...@@ -65,7 +65,7 @@ class urlopenNetworkTests(unittest.TestCase): ...@@ -65,7 +65,7 @@ class urlopenNetworkTests(unittest.TestCase):
def test_readlines(self): def test_readlines(self):
# Test both readline and readlines. # Test both readline and readlines.
with self.urlopen("http://www.python.org/") as open_url: with self.urlopen("http://www.example.com/") as open_url:
self.assertIsInstance(open_url.readline(), bytes, self.assertIsInstance(open_url.readline(), bytes,
"readline did not return a string") "readline did not return a string")
self.assertIsInstance(open_url.readlines(), list, self.assertIsInstance(open_url.readlines(), list,
...@@ -73,7 +73,7 @@ class urlopenNetworkTests(unittest.TestCase): ...@@ -73,7 +73,7 @@ class urlopenNetworkTests(unittest.TestCase):
def test_info(self): def test_info(self):
# Test 'info'. # Test 'info'.
with self.urlopen("http://www.python.org/") as open_url: with self.urlopen("http://www.example.com/") as open_url:
info_obj = open_url.info() info_obj = open_url.info()
self.assertIsInstance(info_obj, email.message.Message, self.assertIsInstance(info_obj, email.message.Message,
"object returned by 'info' is not an " "object returned by 'info' is not an "
...@@ -82,14 +82,14 @@ class urlopenNetworkTests(unittest.TestCase): ...@@ -82,14 +82,14 @@ class urlopenNetworkTests(unittest.TestCase):
def test_geturl(self): def test_geturl(self):
# Make sure same URL as opened is returned by geturl. # Make sure same URL as opened is returned by geturl.
URL = "http://www.python.org/" URL = "http://www.example.com/"
with self.urlopen(URL) as open_url: with self.urlopen(URL) as open_url:
gotten_url = open_url.geturl() gotten_url = open_url.geturl()
self.assertEqual(gotten_url, URL) self.assertEqual(gotten_url, URL)
def test_getcode(self): def test_getcode(self):
# test getcode() with the fancy opener to get 404 error codes # test getcode() with the fancy opener to get 404 error codes
URL = "http://www.python.org/XXXinvalidXXX" URL = "http://www.example.com/XXXinvalidXXX"
with support.transient_internet(URL): with support.transient_internet(URL):
open_url = urllib.request.FancyURLopener().open(URL) open_url = urllib.request.FancyURLopener().open(URL)
try: try:
...@@ -104,7 +104,7 @@ class urlopenNetworkTests(unittest.TestCase): ...@@ -104,7 +104,7 @@ class urlopenNetworkTests(unittest.TestCase):
# test can't pass on Windows. # test can't pass on Windows.
return return
# Make sure fd returned by fileno is valid. # Make sure fd returned by fileno is valid.
with self.urlopen("http://www.python.org/", timeout=None) as open_url: with self.urlopen("http://www.example.com/", timeout=None) as open_url:
fd = open_url.fileno() fd = open_url.fileno()
with os.fdopen(fd, 'rb') as f: with os.fdopen(fd, 'rb') as f:
self.assertTrue(f.read(), "reading from file created using fd " self.assertTrue(f.read(), "reading from file created using fd "
...@@ -148,7 +148,7 @@ class urlretrieveNetworkTests(unittest.TestCase): ...@@ -148,7 +148,7 @@ class urlretrieveNetworkTests(unittest.TestCase):
def test_basic(self): def test_basic(self):
# Test basic functionality. # Test basic functionality.
with self.urlretrieve("http://www.python.org/") as (file_location, info): with self.urlretrieve("http://www.example.com/") as (file_location, info):
self.assertTrue(os.path.exists(file_location), "file location returned by" self.assertTrue(os.path.exists(file_location), "file location returned by"
" urlretrieve is not a valid path") " urlretrieve is not a valid path")
with open(file_location, 'rb') as f: with open(file_location, 'rb') as f:
...@@ -157,7 +157,7 @@ class urlretrieveNetworkTests(unittest.TestCase): ...@@ -157,7 +157,7 @@ class urlretrieveNetworkTests(unittest.TestCase):
def test_specified_path(self): def test_specified_path(self):
# Make sure that specifying the location of the file to write to works. # Make sure that specifying the location of the file to write to works.
with self.urlretrieve("http://www.python.org/", with self.urlretrieve("http://www.example.com/",
support.TESTFN) as (file_location, info): support.TESTFN) as (file_location, info):
self.assertEqual(file_location, support.TESTFN) self.assertEqual(file_location, support.TESTFN)
self.assertTrue(os.path.exists(file_location)) self.assertTrue(os.path.exists(file_location))
...@@ -166,12 +166,12 @@ class urlretrieveNetworkTests(unittest.TestCase): ...@@ -166,12 +166,12 @@ class urlretrieveNetworkTests(unittest.TestCase):
def test_header(self): def test_header(self):
# Make sure header returned as 2nd value from urlretrieve is good. # Make sure header returned as 2nd value from urlretrieve is good.
with self.urlretrieve("http://www.python.org/") as (file_location, info): with self.urlretrieve("http://www.example.com/") as (file_location, info):
self.assertIsInstance(info, email.message.Message, self.assertIsInstance(info, email.message.Message,
"info is not an instance of email.message.Message") "info is not an instance of email.message.Message")
def test_data_header(self): def test_data_header(self):
logo = "http://www.python.org/static/community_logos/python-logo-master-v3-TM.png" logo = "http://www.example.com/"
with self.urlretrieve(logo) as (file_location, fileheaders): with self.urlretrieve(logo) as (file_location, fileheaders):
datevalue = fileheaders.get('Date') datevalue = fileheaders.get('Date')
dateformat = '%a, %d %b %Y %H:%M:%S GMT' dateformat = '%a, %d %b %Y %H:%M:%S GMT'
......
...@@ -76,6 +76,13 @@ Library ...@@ -76,6 +76,13 @@ Library
- Issue #21323: Fix http.server to again handle scripts in CGI subdirectories, - Issue #21323: Fix http.server to again handle scripts in CGI subdirectories,
broken by the fix for security issue #19435. Patch by Zach Byrne. broken by the fix for security issue #19435. Patch by Zach Byrne.
Tests
-----
- Issue #20939: Avoid various network test failures due to new
redirect of http://www.python.org/ to https://www.python.org:
use http://www.example.com instead.
What's New in Python 3.2.5? What's New in Python 3.2.5?
=========================== ===========================
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment