Commit ac4e58eb authored by Éric Araujo's avatar Éric Araujo

Protect logging call against None argument (fixes #11045).

Initial patch by Kelsey Hightower.  Approved by Raymond.  A test was
non-trivial to write without calling the private function directly, so
we moved that for later.
parent 7dabf16f
...@@ -391,7 +391,8 @@ def _make_tarball(base_name, base_dir, compress="gzip", verbose=0, dry_run=0, ...@@ -391,7 +391,8 @@ def _make_tarball(base_name, base_dir, compress="gzip", verbose=0, dry_run=0,
archive_dir = os.path.dirname(archive_name) archive_dir = os.path.dirname(archive_name)
if not os.path.exists(archive_dir): if not os.path.exists(archive_dir):
logger.info("creating %s" % archive_dir) if logger is not None:
logger.info("creating %s" % archive_dir)
if not dry_run: if not dry_run:
os.makedirs(archive_dir) os.makedirs(archive_dir)
......
...@@ -16,6 +16,8 @@ Core and Builtins ...@@ -16,6 +16,8 @@ Core and Builtins
Library Library
------- -------
- Issue #11045: Protect logging call against None argument.
- Issue #11052: Correct IDLE menu accelerators on Mac OS X for Save - Issue #11052: Correct IDLE menu accelerators on Mac OS X for Save
commands. commands.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment