Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
aed8830a
Commit
aed8830a
authored
Sep 19, 2015
by
Raymond Hettinger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a fast path (no iterator creation) for a common case for repeating deques of size 1
parent
02697771
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
20 additions
and
4 deletions
+20
-4
Lib/test/test_deque.py
Lib/test/test_deque.py
+9
-0
Modules/_collectionsmodule.c
Modules/_collectionsmodule.c
+11
-4
No files found.
Lib/test/test_deque.py
View file @
aed8830a
...
...
@@ -654,6 +654,15 @@ class TestBasic(unittest.TestCase):
self
.
assertNotEqual
(
id
(
d
),
id
(
e
))
self
.
assertEqual
(
list
(
d
),
list
(
e
))
for
i
in
range
(
5
):
for
maxlen
in
range
(
-
1
,
6
):
s
=
[
random
.
random
()
for
j
in
range
(
i
)]
d
=
deque
(
s
)
if
maxlen
==
-
1
else
deque
(
s
,
maxlen
)
e
=
d
.
copy
()
self
.
assertEqual
(
d
,
e
)
self
.
assertEqual
(
d
.
maxlen
,
e
.
maxlen
)
self
.
assertTrue
(
all
(
x
is
y
for
x
,
y
in
zip
(
d
,
e
)))
def
test_copy_method
(
self
):
mut
=
[
10
]
d
=
deque
([
mut
])
...
...
Modules/_collectionsmodule.c
View file @
aed8830a
...
...
@@ -1211,6 +1211,7 @@ deque_traverse(dequeobject *deque, visitproc visit, void *arg)
static
PyObject
*
deque_copy
(
PyObject
*
deque
)
{
dequeobject
*
old_deque
=
(
dequeobject
*
)
deque
;
if
(
Py_TYPE
(
deque
)
==
&
deque_type
)
{
dequeobject
*
new_deque
;
PyObject
*
rv
;
...
...
@@ -1218,8 +1219,14 @@ deque_copy(PyObject *deque)
new_deque
=
(
dequeobject
*
)
deque_new
(
&
deque_type
,
(
PyObject
*
)
NULL
,
(
PyObject
*
)
NULL
);
if
(
new_deque
==
NULL
)
return
NULL
;
new_deque
->
maxlen
=
((
dequeobject
*
)
deque
)
->
maxlen
;
rv
=
deque_extend
(
new_deque
,
deque
);
new_deque
->
maxlen
=
old_deque
->
maxlen
;
/* Fast path for the deque_repeat() common case where len(deque) == 1 */
if
(
Py_SIZE
(
deque
)
==
1
&&
new_deque
->
maxlen
!=
0
)
{
PyObject
*
item
=
old_deque
->
leftblock
->
data
[
old_deque
->
leftindex
];
rv
=
deque_append
(
new_deque
,
item
);
}
else
{
rv
=
deque_extend
(
new_deque
,
deque
);
}
if
(
rv
!=
NULL
)
{
Py_DECREF
(
rv
);
return
(
PyObject
*
)
new_deque
;
...
...
@@ -1227,11 +1234,11 @@ deque_copy(PyObject *deque)
Py_DECREF
(
new_deque
);
return
NULL
;
}
if
(
((
dequeobject
*
)
deque
)
->
maxlen
==
-
1
)
if
(
old_deque
->
maxlen
==
-
1
)
return
PyObject_CallFunction
((
PyObject
*
)(
Py_TYPE
(
deque
)),
"O"
,
deque
,
NULL
);
else
return
PyObject_CallFunction
((
PyObject
*
)(
Py_TYPE
(
deque
)),
"Oi"
,
deque
,
((
dequeobject
*
)
deque
)
->
maxlen
,
NULL
);
deque
,
old_deque
->
maxlen
,
NULL
);
}
PyDoc_STRVAR
(
copy_doc
,
"Return a shallow copy of a deque."
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment