Commit aefadd1c authored by Neal Norwitz's avatar Neal Norwitz

Move assert to after NULL check, otherwise we deref NULL in the assert.

Klocwork #307
parent 1b86290a
...@@ -208,12 +208,12 @@ MakeFields(PyObject *type, CFieldObject *descr, ...@@ -208,12 +208,12 @@ MakeFields(PyObject *type, CFieldObject *descr,
continue; continue;
} }
new_descr = (CFieldObject *)PyObject_CallObject((PyObject *)&CField_Type, NULL); new_descr = (CFieldObject *)PyObject_CallObject((PyObject *)&CField_Type, NULL);
assert(new_descr->ob_type == &CField_Type);
if (new_descr == NULL) { if (new_descr == NULL) {
Py_DECREF(fdescr); Py_DECREF(fdescr);
Py_DECREF(fieldlist); Py_DECREF(fieldlist);
return -1; return -1;
} }
assert(new_descr->ob_type == &CField_Type);
new_descr->size = fdescr->size; new_descr->size = fdescr->size;
new_descr->offset = fdescr->offset + offset; new_descr->offset = fdescr->offset + offset;
new_descr->index = fdescr->index + index; new_descr->index = fdescr->index + index;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment