Issue #27533: Release GIL in nt._isdir

b22a6773 · Steve Dower · bc3e9cac · b22a6773 · b22a6773
Commit b22a6773 authored Jul 17, 2016 by Steve Dower
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

Misc/NEWS Misc/NEWS +2 -0

Modules/posixmodule.c Modules/posixmodule.c +2 -0

No files found.
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -28,6 +28,8 @@ Core and Builtins
 Library
 -------

+- Issue #27533: Release GIL in nt._isdir
+
 - Issue #17711: Fixed unpickling by the persistent ID with protocol 0.
  Original patch by Alexandre Vassalotti.


--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -3878,10 +3878,12 @@ os__isdir_impl(PyObject *module, path_t *path)
 {
    DWORD attributes;

+    Py_BEGIN_ALLOW_THREADS
    if (!path->narrow)
        attributes = GetFileAttributesW(path->wide);
    else
        attributes = GetFileAttributesA(path->narrow);
+    Py_END_ALLOW_THREADS

    if (attributes == INVALID_FILE_ATTRIBUTES)
        Py_RETURN_FALSE;