Commit b74cb0ec authored by Victor Stinner's avatar Victor Stinner

get_warnings_attr(): Fix coverity warning

Don't check if the dict key exists before getting the key. Instead get the key
and handle error.
parent 9270fe7f
......@@ -45,7 +45,6 @@ get_warnings_attr(const char *attr, int try_import)
static PyObject *warnings_str = NULL;
PyObject *all_modules;
PyObject *warnings_module, *obj;
int result;
if (warnings_str == NULL) {
warnings_str = PyUnicode_InternFromString("warnings");
......@@ -65,11 +64,11 @@ get_warnings_attr(const char *attr, int try_import)
}
else {
all_modules = PyImport_GetModuleDict();
result = PyDict_Contains(all_modules, warnings_str);
if (result == -1 || result == 0)
return NULL;
warnings_module = PyDict_GetItem(all_modules, warnings_str);
if (warnings_module == NULL)
return NULL;
Py_INCREF(warnings_module);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment