Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
b9183bb4
Commit
b9183bb4
authored
May 14, 2014
by
Serhiy Storchaka
Browse files
Options
Browse Files
Download
Plain Diff
Issue #21075: fileinput.FileInput now reads bytes from standard stream if
binary mode is specified. Patch by Sam Kimbrel.
parents
45e8e2f2
946cfc3e
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
17 additions
and
2 deletions
+17
-2
Lib/fileinput.py
Lib/fileinput.py
+4
-1
Lib/test/test_fileinput.py
Lib/test/test_fileinput.py
+9
-1
Misc/ACKS
Misc/ACKS
+1
-0
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/fileinput.py
View file @
b9183bb4
...
...
@@ -320,7 +320,10 @@ class FileInput:
self
.
_backupfilename
=
0
if
self
.
_filename
==
'-'
:
self
.
_filename
=
'<stdin>'
self
.
_file
=
sys
.
stdin
if
'b'
in
self
.
_mode
:
self
.
_file
=
sys
.
stdin
.
buffer
else
:
self
.
_file
=
sys
.
stdin
self
.
_isstdin
=
True
else
:
if
self
.
_inplace
:
...
...
Lib/test/test_fileinput.py
View file @
b9183bb4
...
...
@@ -19,11 +19,12 @@ try:
except
ImportError
:
gzip
=
None
from
io
import
StringIO
from
io
import
BytesIO
,
StringIO
from
fileinput
import
FileInput
,
hook_encoded
from
test.support
import
verbose
,
TESTFN
,
run_unittest
,
check_warnings
from
test.support
import
unlink
as
safe_unlink
from
unittest
import
mock
# The fileinput module has 2 interfaces: the FileInput class which does
...
...
@@ -232,6 +233,13 @@ class FileInputTests(unittest.TestCase):
finally
:
remove_tempfiles
(
t1
)
def
test_stdin_binary_mode
(
self
):
with
mock
.
patch
(
'sys.stdin'
)
as
m_stdin
:
m_stdin
.
buffer
=
BytesIO
(
b'spam, bacon, sausage, and spam'
)
fi
=
FileInput
(
files
=
[
'-'
],
mode
=
'rb'
)
lines
=
list
(
fi
)
self
.
assertEqual
(
lines
,
[
b'spam, bacon, sausage, and spam'
])
def
test_file_opening_hook
(
self
):
try
:
# cannot use openhook and inplace mode
...
...
Misc/ACKS
View file @
b9183bb4
...
...
@@ -676,6 +676,7 @@ Mads Kiilerich
Jason Killen
Jan Kim
Taek Joo Kim
Sam Kimbrel
W. Trevor King
Paul Kippes
Steve Kirsch
...
...
Misc/NEWS
View file @
b9183bb4
...
...
@@ -84,6 +84,9 @@ Core and Builtins
Library
-------
- Issue #21075: fileinput.FileInput now reads bytes from standard stream if
binary mode is specified. Patch by Sam Kimbrel.
- Issue #19775: Add a samefile() method to pathlib Path objects. Initial
patch by Vajrasky Kok.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment