Commit ba86fa9d authored by Raymond Hettinger's avatar Raymond Hettinger

In Py3.x, a list comprehension is now faster than list(map(itemgetter(0), iterable)).

parent 912fbcad
...@@ -130,7 +130,6 @@ __all__ = ['heappush', 'heappop', 'heapify', 'heapreplace', 'merge', ...@@ -130,7 +130,6 @@ __all__ = ['heappush', 'heappop', 'heapify', 'heapreplace', 'merge',
'nlargest', 'nsmallest', 'heappushpop'] 'nlargest', 'nsmallest', 'heappushpop']
from itertools import islice, repeat, count, tee, chain from itertools import islice, repeat, count, tee, chain
from operator import itemgetter
import bisect import bisect
def heappush(heap, item): def heappush(heap, item):
...@@ -377,13 +376,13 @@ def nsmallest(n, iterable, key=None): ...@@ -377,13 +376,13 @@ def nsmallest(n, iterable, key=None):
if key is None: if key is None:
it = zip(iterable, count()) # decorate it = zip(iterable, count()) # decorate
result = _nsmallest(n, it) result = _nsmallest(n, it)
return list(map(itemgetter(0), result)) # undecorate return [r[0] for r in result] # undecorate
# General case, slowest method # General case, slowest method
in1, in2 = tee(iterable) in1, in2 = tee(iterable)
it = zip(map(key, in1), count(), in2) # decorate it = zip(map(key, in1), count(), in2) # decorate
result = _nsmallest(n, it) result = _nsmallest(n, it)
return list(map(itemgetter(2), result)) # undecorate return [r[2] for r in result] # undecorate
_nlargest = nlargest _nlargest = nlargest
def nlargest(n, iterable, key=None): def nlargest(n, iterable, key=None):
...@@ -415,13 +414,13 @@ def nlargest(n, iterable, key=None): ...@@ -415,13 +414,13 @@ def nlargest(n, iterable, key=None):
if key is None: if key is None:
it = zip(iterable, count(0,-1)) # decorate it = zip(iterable, count(0,-1)) # decorate
result = _nlargest(n, it) result = _nlargest(n, it)
return list(map(itemgetter(0), result)) # undecorate return [r[0] for r in result] # undecorate
# General case, slowest method # General case, slowest method
in1, in2 = tee(iterable) in1, in2 = tee(iterable)
it = zip(map(key, in1), count(0,-1), in2) # decorate it = zip(map(key, in1), count(0,-1), in2) # decorate
result = _nlargest(n, it) result = _nlargest(n, it)
return list(map(itemgetter(2), result)) # undecorate return [r[2] for r in result] # undecorate
if __name__ == "__main__": if __name__ == "__main__":
# Simple sanity test # Simple sanity test
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment