PyObject_RichCompareBool() already returns -1, 0, or 1, so return its value

bb9c5f50 · Neal Norwitz · 884baa1e · bb9c5f50 · bb9c5f50
Commit bb9c5f50 authored Sep 05, 2002 by Neal Norwitz
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 10 deletions

Objects/listobject.c Objects/listobject.c +1 -5

Objects/tupleobject.c Objects/tupleobject.c +1 -5

No files found.
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -325,11 +325,7 @@ list_contains(PyListObject *a, PyObject *el)
 	for (i = 0, cmp = 0 ; cmp == 0 && i < a->ob_size; ++i)
 		cmp = PyObject_RichCompareBool(el, PyList_GET_ITEM(a, i),
 						   Py_EQ);
-	if (cmp > 0)
+	return cmp;
-		return 1;
-	if (cmp < 0)
-		return -1;
-	return 0;
 }

--- a/Objects/tupleobject.c
+++ b/Objects/tupleobject.c
@@ -266,11 +266,7 @@ tuplecontains(PyTupleObject *a, PyObject *el)
 	for (i = 0, cmp = 0 ; cmp == 0 && i < a->ob_size; ++i)
 		cmp = PyObject_RichCompareBool(el, PyTuple_GET_ITEM(a, i),
 						   Py_EQ);
-	if (cmp > 0)
+	return cmp;
-		return 1;
-	if (cmp < 0)
-		return -1;
-	return 0;
 }
 static PyObject *