Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
be7266c6
Commit
be7266c6
authored
May 18, 2013
by
Eli Bendersky
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #17901: fix TreeBuilder construction for an explicit element_factory=None
Based on report and patch by Aaron Oakley.
parent
d22c8fd5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
1 deletion
+8
-1
Lib/test/test_xml_etree.py
Lib/test/test_xml_etree.py
+6
-0
Misc/ACKS
Misc/ACKS
+1
-0
Modules/_elementtree.c
Modules/_elementtree.c
+1
-1
No files found.
Lib/test/test_xml_etree.py
View file @
be7266c6
...
...
@@ -1762,6 +1762,12 @@ class TreeBuilderTest(unittest.TestCase):
parser
.
feed
(
self
.
sample1
)
self
.
assertIsNone
(
parser
.
close
())
def
test_treebuilder_elementfactory_none
(
self
):
parser
=
ET
.
XMLParser
(
target
=
ET
.
TreeBuilder
(
element_factory
=
None
))
parser
.
feed
(
self
.
sample1
)
e
=
parser
.
close
()
self
.
_check_sample1_element
(
e
)
def
test_subclass
(
self
):
class
MyTreeBuilder
(
ET
.
TreeBuilder
):
def
foobar
(
self
,
x
):
...
...
Misc/ACKS
View file @
be7266c6
...
...
@@ -887,6 +887,7 @@ John O'Connor
Kevin O'Connor
Tim O'Malley
Zooko O'Whielacronx
Aaron Oakley
James Oakley
Jon Oberheide
Pascal Oberndoerfer
...
...
Modules/_elementtree.c
View file @
be7266c6
...
...
@@ -2381,7 +2381,7 @@ treebuilder_handle_start(TreeBuilderObject* self, PyObject* tag,
self
->
data
=
NULL
;
}
if
(
self
->
element_factory
)
{
if
(
self
->
element_factory
&&
self
->
element_factory
!=
Py_None
)
{
node
=
PyObject_CallFunction
(
self
->
element_factory
,
"OO"
,
tag
,
attrib
);
}
else
{
node
=
create_new_element
(
tag
,
attrib
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment