Commit bec4d57a authored by Benjamin Peterson's avatar Benjamin Peterson

Merged revisions 74524 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r74524 | gregory.p.smith | 2009-08-20 04:39:38 -0500 (Thu, 20 Aug 2009) | 2 lines

  Add weakref support to the thread.lock type.
........
parent bf2e0aaf
...@@ -61,6 +61,9 @@ instances, functions written in Python (but not in C), instance methods, sets, ...@@ -61,6 +61,9 @@ instances, functions written in Python (but not in C), instance methods, sets,
frozensets, file objects, :term:`generator`\s, type objects, sockets, arrays, frozensets, file objects, :term:`generator`\s, type objects, sockets, arrays,
deques, and regular expression pattern objects. deques, and regular expression pattern objects.
.. versionchanged:: 3.2
Added support for thread.lock and threading.Lock.
Several built-in types such as :class:`list` and :class:`dict` do not directly Several built-in types such as :class:`list` and :class:`dict` do not directly
support weak references but can add support through subclassing:: support weak references but can add support through subclassing::
......
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
/* Interface to Sjoerd's portable C thread library */ /* Interface to Sjoerd's portable C thread library */
#include "Python.h" #include "Python.h"
#include "structmember.h" /* offsetof */
#ifndef WITH_THREAD #ifndef WITH_THREAD
#error "Error! The rest of Python is not compiled with thread support." #error "Error! The rest of Python is not compiled with thread support."
...@@ -20,12 +21,15 @@ static PyObject *ThreadError; ...@@ -20,12 +21,15 @@ static PyObject *ThreadError;
typedef struct { typedef struct {
PyObject_HEAD PyObject_HEAD
PyThread_type_lock lock_lock; PyThread_type_lock lock_lock;
PyObject *in_weakreflist;
} lockobject; } lockobject;
static void static void
lock_dealloc(lockobject *self) lock_dealloc(lockobject *self)
{ {
assert(self->lock_lock); assert(self->lock_lock);
if (self->in_weakreflist != NULL)
PyObject_ClearWeakRefs((PyObject *) self);
/* Unlock the lock so it's safe to free it */ /* Unlock the lock so it's safe to free it */
PyThread_acquire_lock(self->lock_lock, 0); PyThread_acquire_lock(self->lock_lock, 0);
PyThread_release_lock(self->lock_lock); PyThread_release_lock(self->lock_lock);
...@@ -145,7 +149,7 @@ static PyTypeObject Locktype = { ...@@ -145,7 +149,7 @@ static PyTypeObject Locktype = {
0, /*tp_traverse*/ 0, /*tp_traverse*/
0, /*tp_clear*/ 0, /*tp_clear*/
0, /*tp_richcompare*/ 0, /*tp_richcompare*/
0, /*tp_weaklistoffset*/ offsetof(lockobject, in_weakreflist), /*tp_weaklistoffset*/
0, /*tp_iter*/ 0, /*tp_iter*/
0, /*tp_iternext*/ 0, /*tp_iternext*/
lock_methods, /*tp_methods*/ lock_methods, /*tp_methods*/
...@@ -159,6 +163,7 @@ newlockobject(void) ...@@ -159,6 +163,7 @@ newlockobject(void)
if (self == NULL) if (self == NULL)
return NULL; return NULL;
self->lock_lock = PyThread_allocate_lock(); self->lock_lock = PyThread_allocate_lock();
self->in_weakreflist = NULL;
if (self->lock_lock == NULL) { if (self->lock_lock == NULL) {
PyObject_Del(self); PyObject_Del(self);
self = NULL; self = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment