Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
c2155835
Commit
c2155835
authored
Jan 05, 2008
by
Jeffrey Yasskin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make math.floor and math.ceil return ints instead of floats.
parent
d348b258
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
6 deletions
+21
-6
Lib/test/test_math.py
Lib/test/test_math.py
+2
-0
Modules/mathmodule.c
Modules/mathmodule.c
+19
-6
No files found.
Lib/test/test_math.py
View file @
c2155835
...
...
@@ -51,6 +51,7 @@ class MathTests(unittest.TestCase):
def
testCeil
(
self
):
self
.
assertRaises
(
TypeError
,
math
.
ceil
)
self
.
assertEquals
(
int
,
type
(
math
.
ceil
(
0.5
)))
self
.
ftest
(
'ceil(0.5)'
,
math
.
ceil
(
0.5
),
1
)
self
.
ftest
(
'ceil(1.0)'
,
math
.
ceil
(
1.0
),
1
)
self
.
ftest
(
'ceil(1.5)'
,
math
.
ceil
(
1.5
),
2
)
...
...
@@ -103,6 +104,7 @@ class MathTests(unittest.TestCase):
def
testFloor
(
self
):
self
.
assertRaises
(
TypeError
,
math
.
floor
)
self
.
assertEquals
(
int
,
type
(
math
.
floor
(
0.5
)))
self
.
ftest
(
'floor(0.5)'
,
math
.
floor
(
0.5
),
0
)
self
.
ftest
(
'floor(1.0)'
,
math
.
floor
(
1.0
),
1
)
self
.
ftest
(
'floor(1.5)'
,
math
.
floor
(
1.5
),
1
)
...
...
Modules/mathmodule.c
View file @
c2155835
...
...
@@ -48,7 +48,8 @@ is_error(double x)
}
static
PyObject
*
math_1
(
PyObject
*
arg
,
double
(
*
func
)
(
double
))
math_1_to_whatever
(
PyObject
*
arg
,
double
(
*
func
)
(
double
),
PyObject
*
(
*
from_double_func
)
(
double
))
{
double
x
=
PyFloat_AsDouble
(
arg
);
if
(
x
==
-
1
.
0
&&
PyErr_Occurred
())
...
...
@@ -61,7 +62,19 @@ math_1(PyObject *arg, double (*func) (double))
if
(
errno
&&
is_error
(
x
))
return
NULL
;
else
return
PyFloat_FromDouble
(
x
);
return
(
*
from_double_func
)(
x
);
}
static
PyObject
*
math_1
(
PyObject
*
arg
,
double
(
*
func
)
(
double
))
{
return
math_1_to_whatever
(
arg
,
func
,
PyFloat_FromDouble
);
}
static
PyObject
*
math_1_to_int
(
PyObject
*
arg
,
double
(
*
func
)
(
double
))
{
return
math_1_to_whatever
(
arg
,
func
,
PyLong_FromDouble
);
}
static
PyObject
*
...
...
@@ -120,13 +133,13 @@ static PyObject * math_ceil(PyObject *self, PyObject *number) {
method
=
_PyType_Lookup
(
Py_TYPE
(
number
),
ceil_str
);
if
(
method
==
NULL
)
return
math_1
(
number
,
ceil
);
return
math_1
_to_int
(
number
,
ceil
);
else
return
PyObject_CallFunction
(
method
,
"O"
,
number
);
}
PyDoc_STRVAR
(
math_ceil_doc
,
"ceil(x)
\n\n
Return the ceiling of x as a
floa
t.
\n
"
"ceil(x)
\n\n
Return the ceiling of x as a
n in
t.
\n
"
"This is the smallest integral value >= x."
);
FUNC1
(
cos
,
cos
,
...
...
@@ -160,13 +173,13 @@ static PyObject * math_floor(PyObject *self, PyObject *number) {
method
=
_PyType_Lookup
(
Py_TYPE
(
number
),
floor_str
);
if
(
method
==
NULL
)
return
math_1
(
number
,
floor
);
return
math_1_to_int
(
number
,
floor
);
else
return
PyObject_CallFunction
(
method
,
"O"
,
number
);
}
PyDoc_STRVAR
(
math_floor_doc
,
"floor(x)
\n\n
Return the floor of x as a
floa
t.
\n
"
"floor(x)
\n\n
Return the floor of x as a
n in
t.
\n
"
"This is the largest integral value <= x."
);
FUNC2
(
fmod
,
fmod
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment