Commit c2fa9cb0 authored by Johannes Gijsbers's avatar Johannes Gijsbers

SF bug #1076467: don't run test_on_error as root, as the permission

errors don't get provoked that way. Also add a bunch of cross-references
to bugs.
parent 9ce0a385
...@@ -16,7 +16,10 @@ class TestShutil(unittest.TestCase): ...@@ -16,7 +16,10 @@ class TestShutil(unittest.TestCase):
filename = tempfile.mktemp() filename = tempfile.mktemp()
self.assertRaises(OSError, shutil.rmtree, filename) self.assertRaises(OSError, shutil.rmtree, filename)
if hasattr(os, 'chmod') and sys.platform[:6] != 'cygwin': # See bug #1071513 for why we don't run this on cygwin
# and bug #1076467 for why we don't run this as root.
if (hasattr(os, 'chmod') and sys.platform[:6] != 'cygwin'
and os.getenv('USER') != 'root'):
def test_on_error(self): def test_on_error(self):
self.errorState = 0 self.errorState = 0
os.mkdir(TESTFN) os.mkdir(TESTFN)
...@@ -31,7 +34,8 @@ class TestShutil(unittest.TestCase): ...@@ -31,7 +34,8 @@ class TestShutil(unittest.TestCase):
shutil.rmtree(TESTFN, onerror=self.check_args_to_onerror) shutil.rmtree(TESTFN, onerror=self.check_args_to_onerror)
# Test whether onerror has actually been called. # Test whether onerror has actually been called.
self.assertEqual(self.errorState, 2) self.assertEqual(self.errorState, 2,
"Expected call to onerror function did not happen.")
# Make writable again. # Make writable again.
os.chmod(TESTFN, old_dir_mode) os.chmod(TESTFN, old_dir_mode)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment