Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
c6d64ec8
Commit
c6d64ec8
authored
May 17, 2008
by
Benjamin Peterson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
revert 63425 over Guido's Febuary message about this, that I missed
parent
d7943cb7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
45 deletions
+15
-45
Lib/test/test_builtin.py
Lib/test/test_builtin.py
+0
-4
Lib/test/test_py3kwarn.py
Lib/test/test_py3kwarn.py
+0
-14
Python/bltinmodule.c
Python/bltinmodule.c
+15
-27
No files found.
Lib/test/test_builtin.py
View file @
c6d64ec8
...
...
@@ -632,10 +632,6 @@ class BuiltinTest(unittest.TestCase):
self
.
assertEqual
(
hex
(
-
16L
),
'-0x10L'
)
self
.
assertRaises
(
TypeError
,
hex
,
{})
class
Spam
(
object
):
def
__index__
(
self
):
return
23
self
.
assertEqual
(
hex
(
Spam
()),
"0x17"
)
def
test_id
(
self
):
id
(
None
)
id
(
1
)
...
...
Lib/test/test_py3kwarn.py
View file @
c6d64ec8
...
...
@@ -123,20 +123,6 @@ class TestPy3KWarnings(unittest.TestCase):
with
catch_warning
()
as
w
:
self
.
assertWarning
(
buffer
(
'a'
),
w
,
expected
)
def
test_hex_and_oct
(
self
):
class
Spam
(
object
):
def
__hex__
(
self
):
return
"0x17"
def
__oct__
(
self
):
return
"07"
expected
=
'In 3.x, oct() converts the result of __index__ to octal; '
\
'Use future_builtins.oct for this behavior. '
\
'Also, note the returned format is different.'
with
catch_warning
()
as
w
:
self
.
assertWarning
(
oct
(
Spam
()),
w
,
expected
)
expected
=
'In 3.x, hex() converts the result of __index__ to hexadecimal.'
with
catch_warning
()
as
w
:
self
.
assertWarning
(
hex
(
Spam
()),
w
,
expected
)
class
TestStdlibRemovals
(
unittest
.
TestCase
):
...
...
Python/bltinmodule.c
View file @
c6d64ec8
...
...
@@ -1181,29 +1181,22 @@ builtin_hex(PyObject *self, PyObject *v)
{
PyNumberMethods
*
nb
;
PyObject
*
res
;
nb
=
Py_TYPE
(
v
)
->
tp_as_number
;
if
(
nb
!=
NULL
&&
nb
->
nb_hex
!=
NULL
)
{
if
(
PyErr_WarnPy3k
(
"In 3.x, hex() converts "
"the result of __index__ to hexadecimal."
,
1
)
<
0
)
return
NULL
;
res
=
(
*
nb
->
nb_hex
)(
v
);
if
(
res
&&
!
PyString_Check
(
res
))
{
PyErr_Format
(
PyExc_TypeError
,
"__hex__ returned non-string (type %.200s)"
,
res
->
ob_type
->
tp_name
);
Py_DECREF
(
res
);
return
NULL
;
}
return
res
;
if
((
nb
=
v
->
ob_type
->
tp_as_number
)
==
NULL
||
nb
->
nb_hex
==
NULL
)
{
PyErr_SetString
(
PyExc_TypeError
,
"hex() argument can't be converted to hex"
);
return
NULL
;
}
else
if
(
PyIndex_Check
(
v
))
return
PyNumber_ToBase
(
v
,
16
);
PyErr_SetString
(
PyExc_TypeError
,
"hex() argument can't be converted to hex"
);
return
NULL
;
res
=
(
*
nb
->
nb_hex
)(
v
);
if
(
res
&&
!
PyString_Check
(
res
))
{
PyErr_Format
(
PyExc_TypeError
,
"__hex__ returned non-string (type %.200s)"
,
res
->
ob_type
->
tp_name
);
Py_DECREF
(
res
);
return
NULL
;
}
return
res
;
}
PyDoc_STRVAR
(
hex_doc
,
...
...
@@ -1463,11 +1456,6 @@ builtin_oct(PyObject *self, PyObject *v)
"oct() argument can't be converted to oct"
);
return
NULL
;
}
if
(
PyErr_WarnPy3k
(
"In 3.x, oct() converts the result of __index__ to octal; "
"Use future_builtins.oct for this behavior. "
"Also, note the returned format is different."
,
1
)
<
0
)
return
NULL
;
res
=
(
*
nb
->
nb_oct
)(
v
);
if
(
res
&&
!
PyString_Check
(
res
))
{
PyErr_Format
(
PyExc_TypeError
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment