Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
c8d30fec
Commit
c8d30fec
authored
May 20, 2009
by
Jeffrey Yasskin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix issue #1689458 by teaching frame_setlineno how to jump to the first line of
a code object.
parent
cf4ad76a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
41 additions
and
14 deletions
+41
-14
Lib/test/test_trace.py
Lib/test/test_trace.py
+21
-0
Objects/frameobject.c
Objects/frameobject.c
+20
-14
No files found.
Lib/test/test_trace.py
View file @
c8d30fec
...
...
@@ -740,6 +740,27 @@ class JumpTestCase(unittest.TestCase):
def
test_19_no_jump_without_trace_function
(
self
):
no_jump_without_trace_function
()
def
test_jump_to_firstlineno
(
self
):
# This tests that PDB can jump back to the first line in a
# file. See issue #1689458. It can only be triggered in a
# function call if the function is defined on a single line.
code
=
compile
(
"""
# Comments don't count.
output.append(2) # firstlineno is here.
output.append(3)
output.append(4)
"""
,
"<fake module>"
,
"exec"
)
class
fake_function
:
func_code
=
code
jump
=
(
2
,
0
)
tracer
=
JumpTracer
(
fake_function
)
sys
.
settrace
(
tracer
.
trace
)
namespace
=
{
"output"
:
[]}
exec
code
in
namespace
sys
.
settrace
(
None
)
self
.
compare_jump_output
([
2
,
3
,
2
,
3
,
4
],
namespace
[
"output"
])
def
test_main
():
test_support
.
run_unittest
(
TraceTestCase
,
...
...
Objects/frameobject.c
View file @
c8d30fec
...
...
@@ -140,20 +140,26 @@ frame_setlineno(PyFrameObject *f, PyObject* p_new_lineno)
new_lineno
);
return
-
1
;
}
/* Find the bytecode offset for the start of the given line, or the
* first code-owning line after it. */
PyString_AsStringAndSize
(
f
->
f_code
->
co_lnotab
,
&
lnotab
,
&
lnotab_len
);
addr
=
0
;
line
=
f
->
f_code
->
co_firstlineno
;
new_lasti
=
-
1
;
for
(
offset
=
0
;
offset
<
lnotab_len
;
offset
+=
2
)
{
addr
+=
lnotab
[
offset
];
line
+=
lnotab
[
offset
+
1
];
if
(
line
>=
new_lineno
)
{
new_lasti
=
addr
;
new_lineno
=
line
;
break
;
else
if
(
new_lineno
==
f
->
f_code
->
co_firstlineno
)
{
new_lasti
=
0
;
new_lineno
=
f
->
f_code
->
co_firstlineno
;
}
else
{
/* Find the bytecode offset for the start of the given
* line, or the first code-owning line after it. */
PyString_AsStringAndSize
(
f
->
f_code
->
co_lnotab
,
&
lnotab
,
&
lnotab_len
);
addr
=
0
;
line
=
f
->
f_code
->
co_firstlineno
;
new_lasti
=
-
1
;
for
(
offset
=
0
;
offset
<
lnotab_len
;
offset
+=
2
)
{
addr
+=
lnotab
[
offset
];
line
+=
lnotab
[
offset
+
1
];
if
(
line
>=
new_lineno
)
{
new_lasti
=
addr
;
new_lineno
=
line
;
break
;
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment