bpo-36829: test_threading: Fix a ref cycle (GH-13752)

cdce0574 · Victor Stinner · GitHub · aca273e2 · cdce0574
Commit cdce0574 authored Jun 02, 2019 by Victor Stinner Committed by GitHub Jun 02, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

Lib/test/test_threading.py Lib/test/test_threading.py +5 -1

No files found.
--- a/Lib/test/test_threading.py
+++ b/Lib/test/test_threading.py
@@ -1140,7 +1140,11 @@ class ExceptHookTests(BaseTestCase):
                raise ValueError("bug")
            except Exception as exc:
                args = threading.ExceptHookArgs([*sys.exc_info(), None])
-                threading.excepthook(args)
+                try:
+                    threading.excepthook(args)
+                finally:
+                    # Explicitly break a reference cycle
+                    args = None

        stderr = stderr.getvalue().strip()
        self.assertIn(f'Exception in thread {threading.get_ident()}:\n', stderr)