Commit ce6e4b09 authored by R. David Murray's avatar R. David Murray

issue #7728: test_timeout was using a hardcoded port, which was

causing buildbot failures.  Changed to use test_support.bind_port.
Patch by Florent Xicluna.
parent 0877060f
......@@ -101,7 +101,7 @@ class TimeoutTestCase(unittest.TestCase):
def setUp(self):
self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
self.addr_remote = ('www.python.org.', 80)
self.addr_local = ('127.0.0.1', 25339)
self.localhost = '127.0.0.1'
def tearDown(self):
self.sock.close()
......@@ -146,7 +146,8 @@ class TimeoutTestCase(unittest.TestCase):
# Test accept() timeout
_timeout = 2
self.sock.settimeout(_timeout)
self.sock.bind(self.addr_local)
# Prevent "Address already in use" socket exceptions
test_support.bind_port(self.sock, self.localhost)
self.sock.listen(5)
_t1 = time.time()
......@@ -163,7 +164,8 @@ class TimeoutTestCase(unittest.TestCase):
_timeout = 2
self.sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
self.sock.settimeout(_timeout)
self.sock.bind(self.addr_local)
# Prevent "Address already in use" socket exceptions
test_support.bind_port(self.sock, self.localhost)
_t1 = time.time()
self.assertRaises(socket.error, self.sock.recvfrom, 8192)
......
......@@ -150,6 +150,14 @@ Tools/Demos
added to the `Tools/` directory. They were previously living in the
sandbox.
Tests
-----
- issue #7728: test_timeout was changed to use test_support.bind_port
instead of a hard coded port.
Documentation
-------------
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment