Commit cf86b15a authored by Serhiy Storchaka's avatar Serhiy Storchaka

Issue #20604: Added missed invalid mode in error message of socket.makefile().

Based on patch by Franck Michea.
parent 4f879d4a
...@@ -201,9 +201,8 @@ class socket(_socket.socket): ...@@ -201,9 +201,8 @@ class socket(_socket.socket):
except the only mode characters supported are 'r', 'w' and 'b'. except the only mode characters supported are 'r', 'w' and 'b'.
The semantics are similar too. (XXX refactor to share code?) The semantics are similar too. (XXX refactor to share code?)
""" """
for c in mode: if not set(mode) <= {"r", "w", "b"}:
if c not in {"r", "w", "b"}: raise ValueError("invalid mode %r (only r, w, b allowed)" % (mode,))
raise ValueError("invalid mode %r (only r, w, b allowed)")
writing = "w" in mode writing = "w" in mode
reading = "r" in mode or not writing reading = "r" in mode or not writing
assert reading or writing assert reading or writing
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment