Commit d0c3a696 authored by Guido van Rossum's avatar Guido van Rossum

Return -1 for errors.

parent 14e2d0b7
...@@ -107,7 +107,7 @@ module_setattr(m, name, v) ...@@ -107,7 +107,7 @@ module_setattr(m, name, v)
{ {
if (strcmp(name, "__dict__") == 0 || strcmp(name, "__name__") == 0) { if (strcmp(name, "__dict__") == 0 || strcmp(name, "__name__") == 0) {
err_setstr(NameError, "can't assign to reserved member name"); err_setstr(NameError, "can't assign to reserved member name");
return NULL; return -1;
} }
if (v == NULL) if (v == NULL)
return dictremove(m->md_dict, name); return dictremove(m->md_dict, name);
......
...@@ -157,7 +157,7 @@ setattr(v, name, w) ...@@ -157,7 +157,7 @@ setattr(v, name, w)
err_setstr(TypeError, "attribute-less object"); err_setstr(TypeError, "attribute-less object");
else else
err_setstr(TypeError, "object has read-only attributes"); err_setstr(TypeError, "object has read-only attributes");
return NULL; return -1;
} }
else { else {
return (*v->ob_type->tp_setattr)(v, name, w); return (*v->ob_type->tp_setattr)(v, name, w);
......
...@@ -130,5 +130,5 @@ setmember(addr, mlist, name, v) ...@@ -130,5 +130,5 @@ setmember(addr, mlist, name, v)
} }
err_setstr(NameError, name); err_setstr(NameError, name);
return NULL; return -1;
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment