Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
d2b4c19d
Commit
d2b4c19d
authored
Feb 01, 2019
by
Guido van Rossum
Committed by
GitHub
Feb 01, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bpo-35879: Fix type comment leaks (GH-11728)
* Fix leak for # type: ignore * Fix the type comment leak
parent
ac19081c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
3 deletions
+9
-3
Parser/parsetok.c
Parser/parsetok.c
+1
-0
Python/ast.c
Python/ast.c
+8
-3
No files found.
Parser/parsetok.c
View file @
d2b4c19d
...
@@ -330,6 +330,7 @@ parsetok(struct tok_state *tok, grammar *g, int start, perrdetail *err_ret,
...
@@ -330,6 +330,7 @@ parsetok(struct tok_state *tok, grammar *g, int start, perrdetail *err_ret,
}
}
if
(
type
==
TYPE_IGNORE
)
{
if
(
type
==
TYPE_IGNORE
)
{
PyObject_FREE
(
str
);
if
(
!
growable_int_array_add
(
&
type_ignores
,
tok
->
lineno
))
{
if
(
!
growable_int_array_add
(
&
type_ignores
,
tok
->
lineno
))
{
err_ret
->
error
=
E_NOMEM
;
err_ret
->
error
=
E_NOMEM
;
break
;
break
;
...
...
Python/ast.c
View file @
d2b4c19d
...
@@ -699,11 +699,16 @@ ast_error(struct compiling *c, const node *n, const char *errmsg, ...)
...
@@ -699,11 +699,16 @@ ast_error(struct compiling *c, const node *n, const char *errmsg, ...)
*/
*/
static
string
static
string
new_type_comment
(
const
char
*
s
)
new_type_comment
(
const
char
*
s
,
struct
compiling
*
c
)
{
{
return
PyUnicode_DecodeUTF8
(
s
,
strlen
(
s
),
NULL
);
PyObject
*
res
=
PyUnicode_DecodeUTF8
(
s
,
strlen
(
s
),
NULL
);
if
(
PyArena_AddPyObject
(
c
->
c_arena
,
res
)
<
0
)
{
Py_DECREF
(
res
);
return
NULL
;
}
return
res
;
}
}
#define NEW_TYPE_COMMENT(n) new_type_comment(STR(n))
#define NEW_TYPE_COMMENT(n) new_type_comment(STR(n)
, c
)
static
int
static
int
num_stmts
(
const
node
*
n
)
num_stmts
(
const
node
*
n
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment