Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
d354ee65
Commit
d354ee65
authored
Nov 08, 2011
by
Jesus Cea
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Solved a potential deadlock in test_telnetlib.py. Related to issue #11812
parent
7a649b37
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
8 deletions
+2
-8
Lib/test/test_telnetlib.py
Lib/test/test_telnetlib.py
+0
-8
Misc/NEWS
Misc/NEWS
+2
-0
No files found.
Lib/test/test_telnetlib.py
View file @
d354ee65
...
@@ -15,7 +15,6 @@ def server(evt, serv, dataq=None):
...
@@ -15,7 +15,6 @@ def server(evt, serv, dataq=None):
1) set evt to true to let the parent know we are ready
1) set evt to true to let the parent know we are ready
2) [optional] if is not False, write the list of data from dataq.get()
2) [optional] if is not False, write the list of data from dataq.get()
to the socket.
to the socket.
3) set evt to true to let the parent know we're done
"""
"""
serv
.
listen
(
5
)
serv
.
listen
(
5
)
evt
.
set
()
evt
.
set
()
...
@@ -40,7 +39,6 @@ def server(evt, serv, dataq=None):
...
@@ -40,7 +39,6 @@ def server(evt, serv, dataq=None):
conn
.
close
()
conn
.
close
()
finally
:
finally
:
serv
.
close
()
serv
.
close
()
evt
.
set
()
class
GeneralTests
(
TestCase
):
class
GeneralTests
(
TestCase
):
...
@@ -52,11 +50,8 @@ class GeneralTests(TestCase):
...
@@ -52,11 +50,8 @@ class GeneralTests(TestCase):
self
.
thread
=
threading
.
Thread
(
target
=
server
,
args
=
(
self
.
evt
,
self
.
sock
))
self
.
thread
=
threading
.
Thread
(
target
=
server
,
args
=
(
self
.
evt
,
self
.
sock
))
self
.
thread
.
start
()
self
.
thread
.
start
()
self
.
evt
.
wait
()
self
.
evt
.
wait
()
self
.
evt
.
clear
()
time
.
sleep
(.
1
)
def
tearDown
(
self
):
def
tearDown
(
self
):
self
.
evt
.
wait
()
self
.
thread
.
join
()
self
.
thread
.
join
()
def
testBasic
(
self
):
def
testBasic
(
self
):
...
@@ -105,11 +100,8 @@ def _read_setUp(self):
...
@@ -105,11 +100,8 @@ def _read_setUp(self):
self
.
thread
=
threading
.
Thread
(
target
=
server
,
args
=
(
self
.
evt
,
self
.
sock
,
self
.
dataq
))
self
.
thread
=
threading
.
Thread
(
target
=
server
,
args
=
(
self
.
evt
,
self
.
sock
,
self
.
dataq
))
self
.
thread
.
start
()
self
.
thread
.
start
()
self
.
evt
.
wait
()
self
.
evt
.
wait
()
self
.
evt
.
clear
()
time
.
sleep
(.
1
)
def
_read_tearDown
(
self
):
def
_read_tearDown
(
self
):
self
.
evt
.
wait
()
self
.
thread
.
join
()
self
.
thread
.
join
()
class
ReadTests
(
TestCase
):
class
ReadTests
(
TestCase
):
...
...
Misc/NEWS
View file @
d354ee65
...
@@ -359,6 +359,8 @@ Tests
...
@@ -359,6 +359,8 @@ Tests
- Skip network tests when getaddrinfo() returns EAI_AGAIN, meaning a temporary
- Skip network tests when getaddrinfo() returns EAI_AGAIN, meaning a temporary
failure in name resolution.
failure in name resolution.
- Solved a potential deadlock in test_telnetlib.py. Related to issue #11812.
- Avoid failing in test_robotparser when mueblesmoraleda.com is flaky and
- Avoid failing in test_robotparser when mueblesmoraleda.com is flaky and
an overzealous DNS service (e.g. OpenDNS) redirects to a placeholder
an overzealous DNS service (e.g. OpenDNS) redirects to a placeholder
Web site.
Web site.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment