Commit d354ee65 authored by Jesus Cea's avatar Jesus Cea

Solved a potential deadlock in test_telnetlib.py. Related to issue #11812

parent 7a649b37
...@@ -15,7 +15,6 @@ def server(evt, serv, dataq=None): ...@@ -15,7 +15,6 @@ def server(evt, serv, dataq=None):
1) set evt to true to let the parent know we are ready 1) set evt to true to let the parent know we are ready
2) [optional] if is not False, write the list of data from dataq.get() 2) [optional] if is not False, write the list of data from dataq.get()
to the socket. to the socket.
3) set evt to true to let the parent know we're done
""" """
serv.listen(5) serv.listen(5)
evt.set() evt.set()
...@@ -40,7 +39,6 @@ def server(evt, serv, dataq=None): ...@@ -40,7 +39,6 @@ def server(evt, serv, dataq=None):
conn.close() conn.close()
finally: finally:
serv.close() serv.close()
evt.set()
class GeneralTests(TestCase): class GeneralTests(TestCase):
...@@ -52,11 +50,8 @@ class GeneralTests(TestCase): ...@@ -52,11 +50,8 @@ class GeneralTests(TestCase):
self.thread = threading.Thread(target=server, args=(self.evt,self.sock)) self.thread = threading.Thread(target=server, args=(self.evt,self.sock))
self.thread.start() self.thread.start()
self.evt.wait() self.evt.wait()
self.evt.clear()
time.sleep(.1)
def tearDown(self): def tearDown(self):
self.evt.wait()
self.thread.join() self.thread.join()
def testBasic(self): def testBasic(self):
...@@ -105,11 +100,8 @@ def _read_setUp(self): ...@@ -105,11 +100,8 @@ def _read_setUp(self):
self.thread = threading.Thread(target=server, args=(self.evt,self.sock, self.dataq)) self.thread = threading.Thread(target=server, args=(self.evt,self.sock, self.dataq))
self.thread.start() self.thread.start()
self.evt.wait() self.evt.wait()
self.evt.clear()
time.sleep(.1)
def _read_tearDown(self): def _read_tearDown(self):
self.evt.wait()
self.thread.join() self.thread.join()
class ReadTests(TestCase): class ReadTests(TestCase):
......
...@@ -359,6 +359,8 @@ Tests ...@@ -359,6 +359,8 @@ Tests
- Skip network tests when getaddrinfo() returns EAI_AGAIN, meaning a temporary - Skip network tests when getaddrinfo() returns EAI_AGAIN, meaning a temporary
failure in name resolution. failure in name resolution.
- Solved a potential deadlock in test_telnetlib.py. Related to issue #11812.
- Avoid failing in test_robotparser when mueblesmoraleda.com is flaky and - Avoid failing in test_robotparser when mueblesmoraleda.com is flaky and
an overzealous DNS service (e.g. OpenDNS) redirects to a placeholder an overzealous DNS service (e.g. OpenDNS) redirects to a placeholder
Web site. Web site.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment