Commit d3ccde8a authored by Antoine Pitrou's avatar Antoine Pitrou

Issue #7736: Release the GIL around calls to opendir() and closedir()

in the posix module.  Patch by Marcin Bachry.
parent 327fd40d
......@@ -93,6 +93,9 @@ Core and Builtins
Extensions
----------
- Issue #7736: Release the GIL around calls to opendir() and closedir()
in the posix module. Patch by Marcin Bachry.
- Issue #4835: make PyLong_FromSocket_t() and PyLong_AsSocket_t() private
to the socket module, and fix the width of socket descriptors to be
correctly detected under 64-bit Windows.
......
......@@ -2580,11 +2580,16 @@ posix_listdir(PyObject *self, PyObject *args)
oname = PyBytes_FromString(".");
}
name = PyBytes_AsString(oname);
if ((dirp = opendir(name)) == NULL) {
Py_BEGIN_ALLOW_THREADS
dirp = opendir(name);
Py_END_ALLOW_THREADS
if (dirp == NULL) {
return posix_error_with_allocated_filename(oname);
}
if ((d = PyList_New(0)) == NULL) {
Py_BEGIN_ALLOW_THREADS
closedir(dirp);
Py_END_ALLOW_THREADS
Py_DECREF(oname);
return NULL;
}
......@@ -2597,7 +2602,9 @@ posix_listdir(PyObject *self, PyObject *args)
if (errno == 0) {
break;
} else {
Py_BEGIN_ALLOW_THREADS
closedir(dirp);
Py_END_ALLOW_THREADS
Py_DECREF(d);
return posix_error_with_allocated_filename(oname);
}
......@@ -2621,7 +2628,9 @@ posix_listdir(PyObject *self, PyObject *args)
}
Py_DECREF(v);
}
Py_BEGIN_ALLOW_THREADS
closedir(dirp);
Py_END_ALLOW_THREADS
Py_DECREF(oname);
return d;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment