Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
d4367c24
Commit
d4367c24
authored
Oct 17, 2010
by
Matthias Klose
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Merge r81080 from the python2.6 branch:
Issue #8674: fix another bogus overflow check in audioop module.
parent
192b714f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
17 deletions
+8
-17
Modules/audioop.c
Modules/audioop.c
+8
-17
No files found.
Modules/audioop.c
View file @
d4367c24
...
...
@@ -1150,25 +1150,16 @@ audioop_ratecv(PyObject *self, PyObject *args)
ceiling(len*outrate/inrate) output frames, and each frame
requires bytes_per_frame bytes. Computing this
without spurious overflow is the challenge; we can
settle for a reasonable upper bound, though. */
int
ceiling
;
/* the number of output frames */
int
nbytes
;
/* the number of output bytes needed */
int
q
=
len
/
inrate
;
/* Now len = q * inrate + r exactly (with r = len % inrate),
and this is less than q * inrate + inrate = (q+1)*inrate.
So a reasonable upper bound on len*outrate/inrate is
((q+1)*inrate)*outrate/inrate =
(q+1)*outrate.
*/
ceiling
=
(
q
+
1
)
*
outrate
;
nbytes
=
ceiling
*
bytes_per_frame
;
/* See whether anything overflowed; if not, get the space. */
if
(
q
+
1
<
0
||
ceiling
/
outrate
!=
q
+
1
||
nbytes
/
bytes_per_frame
!=
ceiling
)
settle for a reasonable upper bound, though, in this
case ceiling(len/inrate) * outrate. */
/* compute ceiling(len/inrate) without overflow */
int
q
=
len
>
0
?
1
+
(
len
-
1
)
/
inrate
:
0
;
if
(
outrate
>
INT_MAX
/
q
/
bytes_per_frame
)
str
=
NULL
;
else
str
=
PyString_FromStringAndSize
(
NULL
,
nbytes
);
str
=
PyString_FromStringAndSize
(
NULL
,
q
*
outrate
*
bytes_per_frame
);
if
(
str
==
NULL
)
{
PyErr_SetString
(
PyExc_MemoryError
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment