bpo-36155: Check for identity on test_gc.test_get_objects (GH-12116)

d60a79a1 · Pablo Galindo · GitHub · 9add4b33 · d60a79a1
Commit d60a79a1 authored Mar 01, 2019 by Pablo Galindo Committed by GitHub Mar 01, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 36 additions and 12 deletions

Lib/test/test_gc.py Lib/test/test_gc.py +36 -12

No files found.
--- a/Lib/test/test_gc.py
+++ b/Lib/test/test_gc.py
@@ -770,21 +770,45 @@ class GCTests(unittest.TestCase):
        gc.collect()
        l = []
        l.append(l)
-        self.assertIn(l, gc.get_objects(generation=0))
-        self.assertNotIn(l, gc.get_objects(generation=1))
-        self.assertNotIn(l, gc.get_objects(generation=2))
+        self.assertTrue(
+                any(l is element for element in gc.get_objects(generation=0))
+        )
+        self.assertFalse(
+                any(l is element for element in  gc.get_objects(generation=1))
+        )
+        self.assertFalse(
+                any(l is element for element in gc.get_objects(generation=2))
+        )
        gc.collect(generation=0)
-        self.assertNotIn(l, gc.get_objects(generation=0))
-        self.assertIn(l, gc.get_objects(generation=1))
-        self.assertNotIn(l, gc.get_objects(generation=2))
+        self.assertFalse(
+                any(l is element for element in gc.get_objects(generation=0))
+        )
+        self.assertTrue(
+                any(l is element for element in  gc.get_objects(generation=1))
+        )
+        self.assertFalse(
+                any(l is element for element in gc.get_objects(generation=2))
+        )
        gc.collect(generation=1)
-        self.assertNotIn(l, gc.get_objects(generation=0))
-        self.assertNotIn(l, gc.get_objects(generation=1))
-        self.assertIn(l, gc.get_objects(generation=2))
+        self.assertFalse(
+                any(l is element for element in gc.get_objects(generation=0))
+        )
+        self.assertFalse(
+                any(l is element for element in  gc.get_objects(generation=1))
+        )
+        self.assertTrue(
+                any(l is element for element in gc.get_objects(generation=2))
+        )
        gc.collect(generation=2)
-        self.assertNotIn(l, gc.get_objects(generation=0))
-        self.assertNotIn(l, gc.get_objects(generation=1))
-        self.assertIn(l, gc.get_objects(generation=2))
+        self.assertFalse(
+                any(l is element for element in gc.get_objects(generation=0))
+        )
+        self.assertFalse(
+                any(l is element for element in  gc.get_objects(generation=1))
+        )
+        self.assertTrue(
+                any(l is element for element in gc.get_objects(generation=2))
+        )
        del l
        gc.collect()