Commit d6f45b23 authored by Gregory P. Smith's avatar Gregory P. Smith Committed by GitHub

Fix typos in test_faulthandler skipIfs for ubsan. (GH-11386)

parent 6f9bc72c
...@@ -23,11 +23,11 @@ MS_WINDOWS = (os.name == 'nt') ...@@ -23,11 +23,11 @@ MS_WINDOWS = (os.name == 'nt')
_cflags = sysconfig.get_config_var('CFLAGS') or '' _cflags = sysconfig.get_config_var('CFLAGS') or ''
_config_args = sysconfig.get_config_var('CONFIG_ARGS') or '' _config_args = sysconfig.get_config_var('CONFIG_ARGS') or ''
UB_SANITIZER = ( UB_SANITIZER = (
'-fsanitizer=undefined' in _cflags or '-fsanitize=undefined' in _cflags or
'--with-undefined-behavior-sanitizer' in _config_args '--with-undefined-behavior-sanitizer' in _config_args
) )
MEMORY_SANITIZER = ( MEMORY_SANITIZER = (
'-fsanitizer=memory' in _cflags or '-fsanitize=memory' in _cflags or
'--with-memory-sanitizer' in _config_args '--with-memory-sanitizer' in _config_args
) )
...@@ -265,7 +265,7 @@ class FaultHandlerTests(unittest.TestCase): ...@@ -265,7 +265,7 @@ class FaultHandlerTests(unittest.TestCase):
'Segmentation fault') 'Segmentation fault')
@unittest.skipIf(UB_SANITIZER or MEMORY_SANITIZER, @unittest.skipIf(UB_SANITIZER or MEMORY_SANITIZER,
"sanizer builds change crashing process output.") "sanitizer builds change crashing process output.")
@skip_segfault_on_android @skip_segfault_on_android
def test_enable_file(self): def test_enable_file(self):
with temporary_filename() as filename: with temporary_filename() as filename:
...@@ -282,7 +282,7 @@ class FaultHandlerTests(unittest.TestCase): ...@@ -282,7 +282,7 @@ class FaultHandlerTests(unittest.TestCase):
@unittest.skipIf(sys.platform == "win32", @unittest.skipIf(sys.platform == "win32",
"subprocess doesn't support pass_fds on Windows") "subprocess doesn't support pass_fds on Windows")
@unittest.skipIf(UB_SANITIZER or MEMORY_SANITIZER, @unittest.skipIf(UB_SANITIZER or MEMORY_SANITIZER,
"sanizer builds change crashing process output.") "sanitizer builds change crashing process output.")
@skip_segfault_on_android @skip_segfault_on_android
def test_enable_fd(self): def test_enable_fd(self):
with tempfile.TemporaryFile('wb+') as fp: with tempfile.TemporaryFile('wb+') as fp:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment