#13842: check whether PyUnicode_FromString succeeded

dbd7825d · Łukasz Langa · c1f5d8af · dbd7825d
Commit dbd7825d authored Mar 12, 2012 by Łukasz Langa
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 3 deletions

Modules/_pickle.c Modules/_pickle.c +8 -3

No files found.
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -2814,14 +2814,19 @@ save_global(PicklerObject *self, PyObject *obj, PyObject *name)
 static int
 save_ellipsis(PicklerObject *self, PyObject *obj)
 {
-    return save_global(self, Py_Ellipsis, PyUnicode_FromString("Ellipsis"));
+    PyObject *str = PyUnicode_FromString("Ellipsis");
+    if (str == NULL)
+      return -1;
+    return save_global(self, Py_Ellipsis, str);
 }
 static int
 save_notimplemented(PicklerObject *self, PyObject *obj)
 {
-    return save_global(self, Py_NotImplemented,
+    PyObject *str = PyUnicode_FromString("NotImplemented");
-                       PyUnicode_FromString("NotImplemented"));
+    if (str == NULL)
+      return -1;
+    return save_global(self, Py_NotImplemented, str);
 }
 static int