Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
dccfa13c
Commit
dccfa13c
authored
Mar 27, 2014
by
Yury Selivanov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
inspect: Fix getcallargs() to fail correctly if more than 3 args are missing.
Patch by Jeremiah Lowin. Closes #20817.
parent
875df20e
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
1 deletion
+10
-1
Lib/inspect.py
Lib/inspect.py
+1
-1
Lib/test/test_inspect.py
Lib/test/test_inspect.py
+6
-0
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/inspect.py
View file @
dccfa13c
...
...
@@ -1127,7 +1127,7 @@ def _missing_arguments(f_name, argnames, pos, values):
elif
missing
==
2
:
s
=
"{} and {}"
.
format
(
*
names
)
else
:
tail
=
", {} and {}"
.
format
(
names
[
-
2
:])
tail
=
", {} and {}"
.
format
(
*
names
[
-
2
:])
del
names
[
-
2
:]
s
=
", "
.
join
(
names
)
+
tail
raise
TypeError
(
"%s() missing %i required %s argument%s: %s"
%
...
...
Lib/test/test_inspect.py
View file @
dccfa13c
...
...
@@ -1216,6 +1216,12 @@ class TestGetcallargsFunctions(unittest.TestCase):
inspect
.
getcallargs
(
f5
)
# issue20817:
def
f6
(
a
,
b
,
c
):
pass
with
self
.
assertRaisesRegex
(
TypeError
,
"'a', 'b' and 'c'"
):
inspect
.
getcallargs
(
f6
)
class
TestGetcallargsMethods
(
TestGetcallargsFunctions
):
def
setUp
(
self
):
...
...
Misc/NEWS
View file @
dccfa13c
...
...
@@ -116,6 +116,9 @@ Library
-
Issue
#
20816
:
Fix
inspect
.
getcallargs
()
to
raise
correct
TypeError
for
missing
keyword
-
only
arguments
.
Patch
by
Jeremiah
Lowin
.
-
Issue
#
20817
:
Fix
inspect
.
getcallargs
()
to
fail
correctly
if
more
than
3
arguments
are
missing
.
Patch
by
Jeremiah
Lowin
.
Documentation
-------------
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment