Commit ded666ff authored by Antoine Pitrou's avatar Antoine Pitrou Committed by GitHub

[2.7] bpo-30654: Do not reset SIGINT handler to SIG_DFL in finisignal (GH-7146) (GH-7347)

(cherry picked from commit e905c844)
parent 9b5c9488
Fixed reset of the SIGINT handler to SIG_DFL on interpreter shutdown even
when there was a custom handler set previously. Patch by Philipp Kerling.
...@@ -95,13 +95,6 @@ static PyObject *DefaultHandler; ...@@ -95,13 +95,6 @@ static PyObject *DefaultHandler;
static PyObject *IgnoreHandler; static PyObject *IgnoreHandler;
static PyObject *IntHandler; static PyObject *IntHandler;
/* On Solaris 8, gcc will produce a warning that the function
declaration is not a prototype. This is caused by the definition of
SIG_DFL as (void (*)())0; the correct declaration would have been
(void (*)(int))0. */
static PyOS_sighandler_t old_siginthandler = SIG_DFL;
#ifdef HAVE_GETITIMER #ifdef HAVE_GETITIMER
static PyObject *ItimerError; static PyObject *ItimerError;
...@@ -629,7 +622,7 @@ initsignal(void) ...@@ -629,7 +622,7 @@ initsignal(void)
/* Install default int handler */ /* Install default int handler */
Py_INCREF(IntHandler); Py_INCREF(IntHandler);
Py_SETREF(Handlers[SIGINT].func, IntHandler); Py_SETREF(Handlers[SIGINT].func, IntHandler);
old_siginthandler = PyOS_setsig(SIGINT, signal_handler); PyOS_setsig(SIGINT, signal_handler);
} }
#ifdef SIGHUP #ifdef SIGHUP
...@@ -872,14 +865,11 @@ finisignal(void) ...@@ -872,14 +865,11 @@ finisignal(void)
int i; int i;
PyObject *func; PyObject *func;
PyOS_setsig(SIGINT, old_siginthandler);
old_siginthandler = SIG_DFL;
for (i = 1; i < NSIG; i++) { for (i = 1; i < NSIG; i++) {
func = Handlers[i].func; func = Handlers[i].func;
Handlers[i].tripped = 0; Handlers[i].tripped = 0;
Handlers[i].func = NULL; Handlers[i].func = NULL;
if (i != SIGINT && func != NULL && func != Py_None && if (func != NULL && func != Py_None &&
func != DefaultHandler && func != IgnoreHandler) func != DefaultHandler && func != IgnoreHandler)
PyOS_setsig(i, SIG_DFL); PyOS_setsig(i, SIG_DFL);
Py_XDECREF(func); Py_XDECREF(func);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment