Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
e0793ba9
Commit
e0793ba9
authored
Sep 01, 2010
by
Antoine Pitrou
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #9737: Fix a crash when trying to delete a slice or an item from
a memoryview object.
parent
6cb5ad03
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
0 deletions
+17
-0
Lib/test/test_memoryview.py
Lib/test/test_memoryview.py
+9
-0
Misc/NEWS
Misc/NEWS
+3
-0
Objects/memoryobject.c
Objects/memoryobject.c
+5
-0
No files found.
Lib/test/test_memoryview.py
View file @
e0793ba9
...
...
@@ -111,6 +111,15 @@ class AbstractMemoryTests:
m
=
None
self
.
assertEquals
(
sys
.
getrefcount
(
b
),
oldrefcount
)
def
test_delitem
(
self
):
for
tp
in
self
.
_types
:
b
=
tp
(
self
.
_source
)
m
=
self
.
_view
(
b
)
with
self
.
assertRaises
(
TypeError
):
del
m
[
1
]
with
self
.
assertRaises
(
TypeError
):
del
m
[
1
:
4
]
def
test_tobytes
(
self
):
for
tp
in
self
.
_types
:
m
=
self
.
_view
(
tp
(
self
.
_source
))
...
...
Misc/NEWS
View file @
e0793ba9
...
...
@@ -12,6 +12,9 @@ What's New in Python 3.2 Alpha 2?
Core and Builtins
-----------------
- Issue #9737: Fix a crash when trying to delete a slice or an item from
a memoryview object.
- Issue #9549: sys.setdefaultencoding() and PyUnicode_SetDefaultEncoding()
are now removed, since their effect was inexistent in 3.x (the default
encoding is hardcoded to utf-8 and cannot be changed).
...
...
Objects/memoryobject.c
View file @
e0793ba9
...
...
@@ -631,6 +631,11 @@ memory_ass_sub(PyMemoryViewObject *self, PyObject *key, PyObject *value)
"cannot modify read-only memory"
);
return
-
1
;
}
if
(
value
==
NULL
)
{
PyErr_SetString
(
PyExc_TypeError
,
"cannot delete memory"
);
return
-
1
;
}
if
(
view
->
ndim
!=
1
)
{
PyErr_SetNone
(
PyExc_NotImplementedError
);
return
-
1
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment