Commit e0bb597d authored by Tim Peters's avatar Tim Peters

test_timeout(): This test was added during Bug Day, but disabled

soon after because the gmail address it connects to started timing
out on all the buildbot slaves.  Rewrote the test to produce a
warning message (instead of failing) when the address times out.

Also removed the special case for Windows -- this test started to
work on Windows as soon as bug 1462352 was fixed.
parent 2f36caf8
...@@ -14,6 +14,9 @@ def test_basic(): ...@@ -14,6 +14,9 @@ def test_basic():
import urllib import urllib
if test_support.verbose:
print "test_basic ..."
socket.RAND_status() socket.RAND_status()
try: try:
socket.RAND_egd(1) socket.RAND_egd(1)
...@@ -27,28 +30,41 @@ def test_basic(): ...@@ -27,28 +30,41 @@ def test_basic():
buf = f.read() buf = f.read()
f.close() f.close()
# XXX Tim disabled this test on all platforms, for now, since the def test_timeout():
# XXX s.connect(("gmail.org", 995)) test_support.requires('network')
# XXX line starting timing out on all the builbot slaves.
if 0: #not sys.platform.startswith('win'): if test_support.verbose:
def test_timeout(): print "test_timeout ..."
test_support.requires('network')
# A service which issues a welcome banner (without need to write
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) # anything).
s.settimeout(30.0) # XXX ("gmail.org", 995) has been unreliable so far, from time to time
# connect to service which issues an welcome banner (without need to # XXX non-responsive for hours on end (& across all buildbot slaves,
# write anything) # XXX so that's not just a local thing).
s.connect(("gmail.org", 995)) ADDR = "gmail.org", 995
ss = socket.ssl(s)
# read part of return welcome banner twice s = socket.socket()
ss.read(1) s.settimeout(30.0)
ss.read(1) try:
s.close() s.connect(ADDR)
else: except socket.timeout:
def test_timeout(): print >> sys.stderr, """\
pass WARNING: an attempt to connect to %r timed out, in
test_timeout. That may be legitimate, but is not the outcome we hoped
for. If this message is seen often, test_timeout should be changed to
use a more reliable address.""" % (ADDR,)
return
ss = socket.ssl(s)
# Read part of return welcome banner twice.
ss.read(1)
ss.read(1)
s.close()
def test_rude_shutdown(): def test_rude_shutdown():
if test_support.verbose:
print "test_rude_shutdown ..."
try: try:
import threading import threading
except ImportError: except ImportError:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment